Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pylama #928

Merged
merged 1 commit into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,6 @@ jobs:

- name: Run ruff
run: make ruff
- name: Run pylama
run: make pylama
- name: Run black
run: make black
- name: Run mypy
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ The Black GitHub repo has information about how you can integrate Black in your

Tests
-------------
As part of the automatic CI on every pull request, besides coding style checks with ``black``, we also do linting with ``pylama``, static type checking with ``mypy``, unit tests with ``pytest``, docs generation with ``sphinx`` and ``nbsphinx`` (for Jupyter notebooks) and verification of outputs in Jupyter notebook tutorials with pytest plugin ``nbval``.
As part of the automatic CI on every pull request, besides coding style checks with ``black``, we also do linting with ``ruff``, static type checking with ``mypy``, unit tests with ``pytest``, docs generation with ``sphinx`` and ``nbsphinx`` (for Jupyter notebooks) and verification of outputs in Jupyter notebook tutorials with pytest plugin ``nbval``.

After modifying any code in the core, at first, we recommend running unit tests locally before running the whole test suite (which takes longer time):

Expand Down
6 changes: 1 addition & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ sphinx:
# poetry run sphinx-build -W -b html -d docs/_build/doctrees docs docs/_build/html
echo "WARNING: sphinx needs to be added here!!!"

.PHONY: pylama
pylama:
poetry run pylama ${NORNIR_DIRS}

.PHONY: mypy
mypy:
poetry run mypy nornir tests
Expand All @@ -44,7 +40,7 @@ ruff:
poetry run ruff check .

.PHONY: tests
tests: ruff black pylama mypy nbval pytest sphinx
tests: ruff black mypy nbval pytest sphinx

.PHONY: docker-tests
docker-tests: docker
Expand Down
79 changes: 1 addition & 78 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ decorator = "*"
nbval = "^0.10.0"
pytest = "*"
pytest-cov = "*"
pylama = "*"
requests-mock = "*"
black = "^23.9.1"
isort = "^5.12.0"
Expand Down
19 changes: 0 additions & 19 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,6 @@
# will need to generate wheels for each Python version that you support.
universal=1

# E127: continuation line over-indented for visual indent
# E128: continuation line under-indented for visual indent
# E265: block comment should start with #
# E731: do not assign a lambda expression, use a def
# D10?: missing docstrings
[pylama]
linters = mccabe,pycodestyle,pyflakes
ignore = D203,C901,W503
skip = .tox/*,.venv/*,nornir/_vendor/*

[pylama:pycodestyle]
max_line_length = 100

[pycodestyle]
ignore = D203,C901,W503
exclude = .git,__pycache__,build,dist
max-complexity = 10
max-line-length = 100

[tool:pytest]
#addopts = --cov=nornir --cov-report=term-missing -vs
filterwarnings =
Expand Down