Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary assignment before return statement #958

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

ogenstad
Copy link
Collaborator

@ogenstad ogenstad commented Jul 1, 2024

No description provided.

@ogenstad ogenstad marked this pull request as ready for review July 1, 2024 15:26
@ktbyers
Copy link
Collaborator

ktbyers commented Jul 1, 2024

Ruff is convincing me not to use it in other projects (LOL).

@ktbyers ktbyers merged commit 0d03b6e into main Jul 1, 2024
26 checks passed
@ktbyers ktbyers deleted the ogenstad/return-assignment branch July 1, 2024 18:53
@ogenstad
Copy link
Collaborator Author

ogenstad commented Jul 1, 2024

Ruff is convincing me not to use it in other projects (LOL).

Well it mostly reimplements rules from other linters, though it has a few rules of its own too. I think most of the rules make sense and adds clarity. As with other linkers it's always easier if it's in place when you start coding instead of going back and adding it later.

@ktbyers
Copy link
Collaborator

ktbyers commented Jul 1, 2024

Yeah, it doesn't really matter (as with almost all linter things--it just matters that it is done/decided automatically).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants