New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update spec for timestamping #290

Merged

yizha1 merged 81 commits into notaryproject:main from Two-Hearts:tsa

Jun 20, 2024

Contributor

Two-Hearts commented Dec 25, 2023 •

edited

Loading

Improving Notary Project specs regarding timestamping and TSA.

Resolves #288

Two-Hearts added 2 commits

December 25, 2023 13:58


          specs related to Timestamping

3ea8e20

Signed-off-by: Patrick Zheng <[email protected]>


          update

b87fd4c

Signed-off-by: Patrick Zheng <[email protected]>

Two-Hearts requested review from gokarnm, justincormack, NiazFK, priteshbandi, SteveLasker, shizhMSFT, toddysm, vaninrao10 and yizha1 as code owners

December 25, 2023 08:08

yizha1 reviewed

View reviewed changes

Contributor

yizha1 left a comment

Thanks @Two-Hearts . Some comments

specs/signature-specification.md Show resolved Hide resolved

specs/signature-specification.md Outdated Show resolved Hide resolved

specs/signing-and-verification-workflow.md Outdated Show resolved Hide resolved

specs/signing-scheme.md Outdated Show resolved Hide resolved


          update

4478a2c

Signed-off-by: Patrick Zheng <[email protected]>

FeynmanZhou reviewed

View reviewed changes

specs/signature-envelope-cose.md Outdated Show resolved Hide resolved

FeynmanZhou reviewed

View reviewed changes

specs/signature-envelope-jws.md Outdated Show resolved Hide resolved

FeynmanZhou reviewed

View reviewed changes

specs/signature-specification.md Outdated Show resolved Hide resolved

FeynmanZhou reviewed

View reviewed changes

specs/signature-specification.md Outdated Show resolved Hide resolved


          update

576e605

Signed-off-by: Patrick Zheng <[email protected]>

FeynmanZhou reviewed

View reviewed changes

specs/signing-scheme.md Outdated Show resolved Hide resolved

Two-Hearts added 5 commits

December 27, 2023 12:57


          update

6093caf

Signed-off-by: Patrick Zheng <[email protected]>


          update

a5f9f11

Signed-off-by: Patrick Zheng <[email protected]>


          update

b2359ba

Signed-off-by: Patrick Zheng <[email protected]>


          update

b4125e1

Signed-off-by: Patrick Zheng <[email protected]>


          update

e36692a

Signed-off-by: Patrick Zheng <[email protected]>

Two-Hearts requested review from FeynmanZhou and yizha1

December 27, 2023 05:38


          updated

0e8eb01

Signed-off-by: Patrick Zheng <[email protected]>

shizhMSFT requested changes

View reviewed changes

Contributor

shizhMSFT left a comment

Since there is a misunderstanding of crypto concepts, I would like to sync up with you offline for clarification before continue reviewing.

specs/plugin-extensibility.md Outdated Show resolved Hide resolved

specs/signature-specification.md Outdated Show resolved Hide resolved

specs/signature-specification.md Outdated Show resolved Hide resolved

specs/signature-specification.md Outdated Show resolved Hide resolved

specs/signature-specification.md Outdated Show resolved Hide resolved

Two-Hearts added 2 commits

December 28, 2023 16:42


          updated per review

eeb56d3

Signed-off-by: Patrick Zheng <[email protected]>


          update

010aca5

Signed-off-by: Patrick Zheng <[email protected]>

Two-Hearts added 3 commits

June 6, 2024 09:03


          update

bc02398

Signed-off-by: Patrick Zheng <[email protected]>


          update

d183283

Signed-off-by: Patrick Zheng <[email protected]>


          updated per review

dc8c42d

Signed-off-by: Patrick Zheng <[email protected]>

Two-Hearts requested review from priteshbandi, shizhMSFT, yizha1 and FeynmanZhou

June 14, 2024 03:26

shizhMSFT previously approved these changes

View reviewed changes

Contributor

shizhMSFT left a comment

LGTM

yizha1 previously approved these changes

View reviewed changes

Contributor

yizha1 left a comment

LGTM


          update

b808eaa

Signed-off-by: Patrick Zheng <[email protected]>

Two-Hearts dismissed stale reviews from yizha1 and shizhMSFT via

b808eaa

June 17, 2024 08:27

Two-Hearts requested review from shizhMSFT and yizha1

June 17, 2024 08:28

shizhMSFT previously approved these changes

View reviewed changes

Contributor

shizhMSFT left a comment

LGTM

yizha1 previously approved these changes

View reviewed changes

Contributor

yizha1 left a comment

LGTM

FeynmanZhou previously approved these changes

View reviewed changes

Member

FeynmanZhou left a comment

LGTM

yizha1 mentioned this pull request

Follow-up on handling TSA SHA1 algorithm #302

Closed

priteshbandi reviewed

View reviewed changes

specs/plugin-extensibility.md Outdated Show resolved Hide resolved

specs/plugin-extensibility.md Outdated Show resolved Hide resolved

specs/plugin-extensibility.md Show resolved Hide resolved

specs/signing-and-verification-workflow.md Outdated Show resolved Hide resolved

specs/signing-scheme.md Show resolved Hide resolved

specs/trust-store-trust-policy.md Outdated Show resolved Hide resolved

specs/trust-store-trust-policy.md Show resolved Hide resolved

specs/trust-store-trust-policy.md Show resolved Hide resolved

Two-Hearts mentioned this pull request

Revocation check control for timestamp verification #303

Open


          updated based on review

3ad24c2

Signed-off-by: Patrick Zheng <[email protected]>

Two-Hearts dismissed stale reviews from FeynmanZhou, yizha1, and shizhMSFT via

3ad24c2

June 20, 2024 01:57

Two-Hearts requested a review from priteshbandi

June 20, 2024 01:59

priteshbandi approved these changes

View reviewed changes

Contributor

priteshbandi left a comment •

edited

Loading

LGTM with following open issues that we will address before 1.1 release

shizhMSFT approved these changes

View reviewed changes

Contributor

shizhMSFT left a comment

LGTM

yizha1 approved these changes

View reviewed changes

Contributor

yizha1 left a comment

LGTM. Thanks @Two-Hearts

yizha1 merged commit 3b0743c into notaryproject:main

1 check passed

Two-Hearts deleted the tsa branch

June 20, 2024 05:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

priteshbandi priteshbandi approved these changes

shizhMSFT shizhMSFT approved these changes

yizha1 yizha1 approved these changes

FeynmanZhou FeynmanZhou left review comments

gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

justincormack Awaiting requested review from justincormack

NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

SteveLasker Awaiting requested review from SteveLasker

toddysm Awaiting requested review from toddysm toddysm is a code owner

vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

JeyJeyGao Awaiting requested review from JeyJeyGao

Labels

None yet