Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to @noundry/nouns-assets #884

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

volkyeth
Copy link
Contributor

@volkyeth volkyeth commented Feb 17, 2025

nouns.wtf is out of date again, missing the Lilac body

This PR switches from the @nomonouns/assets package to @noundry/nouns-assets
that is a slightly modified version of @nouns/assets which uses more up-to-date assets if available, and fallbacks to the package assets.

It also adds a script fetching the latest assets from https://assets.noundry.wtf/nouns/image-data.js
this script injects the most up-to-date assets for @noundry/nouns-assets to use.

Those assets are generated directly from the onchain data, so they'll always be up-to-date. No more need to update the package and push a new deployment all the time.

As a proof of concept, the current image-data.json from @noundry/nouns-assets does not contain the Lilac body. It is nevertheless loaded from the assets.noundry.wtf API and is available on the app:

CleanShot 2025-02-17 at 14 50 37@2x
(tested locally)

Obs: although this solution adds a dependency to the assets.noundry.wtf API, in a scenario where it's unavailable, the app will still load as usual, falling back to the assets included with @noundry/nouns-assets

@lastpunk9999 lastpunk9999 self-requested a review February 27, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant