Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nouns.wtf is out of date again, missing the Lilac body
This PR switches from the @nomonouns/assets package to @noundry/nouns-assets
that is a slightly modified version of @nouns/assets which uses more up-to-date assets if available, and fallbacks to the package assets.
It also adds a script fetching the latest assets from https://assets.noundry.wtf/nouns/image-data.js
this script injects the most up-to-date assets for @noundry/nouns-assets to use.
Those assets are generated directly from the onchain data, so they'll always be up-to-date. No more need to update the package and push a new deployment all the time.
As a proof of concept, the current image-data.json from @noundry/nouns-assets does not contain the Lilac body. It is nevertheless loaded from the assets.noundry.wtf API and is available on the app:
(tested locally)
Obs: although this solution adds a dependency to the assets.noundry.wtf API, in a scenario where it's unavailable, the app will still load as usual, falling back to the assets included with @noundry/nouns-assets