feat: basket feature refactoring #3117
Open
+3,852
−2,850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Asmadek
commented
Feb 7, 2025
Asmadek
commented
- refactor basket to operations features
Unit Test Results 1 files 159 suites 6s ⏱️ For more details on these failures, see this check. Results for commit 7f5fcde. ♻️ This comment has been updated with latest results. |
johnthecat
reviewed
Feb 10, 2025
| @@ -6,7 +6,7 @@ export type BasketTransaction = { | |||
| initiatorWallet: ID; | |||
| coreTx: Transaction; | |||
| txWrappers: TxWrapper[]; | |||
| error?: BasketError; | |||
| error?: ChainError | ClientError; | |||
There was a problem hiding this comment.
You want to store error in DB? why?
src/renderer/features/basket-filter/model/baket-filter-model.ts
Outdated
Show resolved
Hide resolved
| const isSignAvailable = selectedTxs.length > 0; | ||
|
|
||
| useEffect(() => { | ||
| selectOperations.filterTxs(operations); |
There was a problem hiding this comment.
You can filter operations inside effector
|
|
||
| export const operationTitleSlot = createSlot<SlotProps>(); | ||
|
|
||
| export const Operation = ({ operation }: Props) => { |
There was a problem hiding this comment.
Do you need separated component for this? use <Slot id={operationTitleSlot} props={{ operation }}/> in parent component
| export const confirmTitleSlot = createSlot<SlotProps>(); | ||
| export const confirmDetailsSlot = createSlot<SlotProps>(); | ||
|
|
||
| export const OperationConfirm = ({ operation }: Props) => { |
|
|
||
| import { WalletType } from '@/shared/core'; | ||
| import { useSlot } from '@/shared/di'; | ||
| import { useModalClose } from '@/shared/lib/hooks'; |
There was a problem hiding this comment.
We don't need it anymore
| } | ||
|
|
||
| return ( | ||
| <BaseModal |
There was a problem hiding this comment.
Let's refactor it, use Modal instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.