Myth staking/selected collators #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
valentunn
commented
Jan 30, 2025
valentunn
commented
antonijzelinskij
approved these changes
Jan 31, 2025
Comment on lines
65
to
+68
| totalStake = collatorStake.stake, | ||
| delegators = collatorStake.stakers, | ||
| // TODO APY calculation | ||
| apr = Fraction.ZERO | ||
| apr = Fraction.ZERO.takeIf { collatorId in sessionValidators } |
There was a problem hiding this comment.
What do you think about adding a field isActive to this model?
Or we can create a sealed class here
I think it's more readable than relying on nullable field
| @@ -4,7 +4,7 @@ import io.novafoundation.nova.common.base.BaseViewModel | |||
| import io.novafoundation.nova.common.presentation.LoadingState | |||
| import kotlinx.coroutines.flow.Flow | |||
|
|
|||
| abstract class CurrentStakeTargetsViewModel : BaseViewModel() { | |||
| abstract class CurrentStakeTargetsViewModel: BaseViewModel() { | |||
There was a problem hiding this comment.
Should have a space
| .shareInBackground() | ||
|
|
||
| private val flattenCurrentCollators = groupedCurrentCollatorsFlow | ||
| .map { it.toValueList() } |
There was a problem hiding this comment.
What do you think about rename toValueList to flatMapValuesToList?
There was a problem hiding this comment.
Yeah worth renaming, andflattenValues looks even better, following the naming of Iterable<Itereable<T>>.flatten(): List<T> from stdlib
Base automatically changed from
myth_staking/claim_rewards
to
myth_staking_base
February 10, 2025 09:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.