-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add exponential retry mechanism #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't looked in detail but it seems good to me in terms of functionality.
On the other hand, I am against adding a new dependency for clients while these functionalities already exist in the library that we use. See the following links:
Thanks for the feedback @ryshu . I was about to use the Afaik, they also provide less customization / parameters so it will make the configuration differ from the existing method in go SDK. |
For me, this is precisely what is interesting:
For me, there is no problem with the fact that we do not have all the functionalities of the GO lib as long as the behavior (exponential retry via the WDYT @Cliftonz ? |
I would like to know your opinion before changing this pr @Cliftonz |
@im-perativa I agree with ryshu the backoff strategy is important. I do want to specify that by default retry should not be on, as we want users to specifically opt into this and it changes the priority of Novu from availability to consistency. @ryshu what features are you not able to do 1:1? |
Ok for the opt-in instead off opt-out. @im-perativa Can you clarify the missing functionnality implemented in go sdk ? |
Please, how can we move forward here? @ryshu |
Hi @unicodeveloper, Reply pending from @im-perativa in fact |
@ryshu Sorry I'm not sure if I will have the capacity to modify it in timely manner so that no external dependencies is added, nor do I think it will be an elegant solution. Feel free to reassign the issue or modify it |
closes #91
This PR
requests.Session
Sample usage: