-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): remove environment id from get integration #6493
base: next
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the environment come from the Novu-Environment-Id http header? Since we have separate integrations per environment, shouldn't the environment be set regardless but not from the header?
environmentId comes with user session. Production integrations can be accessed from the development environment. CleanShot.2024-09-13.at.22.54.57.mp4 |
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Could you please review this PR again? |
What changed? Why was the change needed?
When user is in development environment and go to production sendgrid integration, webhook URL is not showing because at API level, _environmentId is still development one and integration is not found in development env. Above case can be reproducesd for development integrations in the production environment.
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer