Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): remove environment id from get integration #6493

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

jainpawan21
Copy link
Member

@jainpawan21 jainpawan21 commented Sep 12, 2024

What changed? Why was the change needed?

When user is in development environment and go to production sendgrid integration, webhook URL is not showing because at API level, _environmentId is still development one and integration is not found in development env. Above case can be reproducesd for development integrations in the production environment.

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link
Contributor

@SokratisVidros SokratisVidros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the environment come from the Novu-Environment-Id http header? Since we have separate integrations per environment, shouldn't the environment be set regardless but not from the header?

@jainpawan21
Copy link
Member Author

Does the environment come from the Novu-Environment-Id http header? Since we have separate integrations per environment, shouldn't the environment be set regardless but not from the header?

environmentId comes with user session. Production integrations can be accessed from the development environment.

CleanShot.2024-09-13.at.22.54.57.mp4

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 09b27c1
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/671689f9886d7a0008c28ff1
😎 Deploy Preview https://deploy-preview-6493--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jainpawan21
Copy link
Member Author

@SokratisVidros

Could you please review this PR again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants