fix(js): Remove @novu/shared dependency #6906
Draft
+231
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SokratisVidros
force-pushed
the
remove_shared_from_js
branch
from
93da3ec
to
e8a6c4f
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
@novu/client
@novu/framework
@novu/headless
@novu/js
@novu/nest
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
BiswaViraj
reviewed
Nov 12, 2024
| @@ -32,7 +26,6 @@ export class Novu implements Pick<NovuEventEmitter, 'on'> { | |||
| constructor(options: NovuOptions) { | |||
| this.#inboxService = new InboxService({ | |||
| backendUrl: options.backendUrl ?? PRODUCTION_BACKEND_URL, | |||
| userAgent: options.__userAgent ?? userAgent, | |||
There was a problem hiding this comment.
This is needed for useragent analytics from @novu/react and other packages
There was a problem hiding this comment.
Good catch. I will add it back.
Clone HTTP client from @novu/client to remove all @novu/shared leakages in @novu/js
SokratisVidros
force-pushed
the
remove_shared_from_js
branch
from
e8a6c4f
to
64d796d
Compare
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
SokratisVidros
temporarily deployed
to
Linting
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Clone HTTP client from @novu/client to remove all @novu/shared leakages in @novu/js