feat(application-generic): add SUBSCRIBER_WIDGET_JWT_EXPIRATION_TIME env variable #7105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainpawan21
requested review from
SokratisVidros and
scopsy
and removed request for
a team
jainpawan21
changed the title
jainpawan21
changed the title
scopsy
approved these changes
Nov 21, 2024
scopsy
reviewed
Nov 21, 2024
| @@ -87,3 +87,5 @@ TUNNEL_BASE_ADDRESS= | |||
| PLAIN_SUPPORT_KEY='PLAIN_SUPPORT_KEY' | |||
| PLAIN_IDENTITY_VERIFICATION_SECRET_KEY='PLAIN_IDENTITY_VERIFICATION_SECRET_KEY' | |||
| NOVU_INTERNAL_SECRET_KEY= | |||
| # expressed in seconds or a string describing a time span [zeit/ms](https://github.com/zeit/ms.js). Eg: 60, "2 days", "10h", "7d" | |||
There was a problem hiding this comment.
@jainpawan21 are comments allowed in a .env file? (don't remember if they do)
There was a problem hiding this comment.
Yeah .env file supports comments
https://dotenvx.com/docs/env-file
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
merrcury
requested changes
Nov 25, 2024
libs/application-generic/src/services/auth/community.auth.service.ts
Outdated
Show resolved
Hide resolved
…novu into feature/widget_jwt_expire_config
github-actions
bot
added
@novu/api
@novu/web
@novu/dal
@novu/shared
@novu/worker
labels
scopsy
approved these changes
Nov 27, 2024
merrcury
pushed a commit
that referenced
this pull request
Nov 28, 2024
…env variable (#7105) Co-authored-by: Dima Grossman <[email protected]>
SokratisVidros
pushed a commit
that referenced
this pull request
Nov 28, 2024
…env variable (#7105) Co-authored-by: Dima Grossman <[email protected]>
ChmaraX
pushed a commit
that referenced
this pull request
Nov 28, 2024
…env variable (#7105) Co-authored-by: Dima Grossman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
add
SUBSCRIBER_WIDGET_JWT_EXPIRATION_TIMEenv variable to customize subscriber widget jwt expire timeref:- Slack conversation
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer