-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete account view with basic bloc #296
Conversation
|
||
await _userService.deleteUser(); | ||
await _authenticationService.logout(); | ||
_appRouter.pushAndPopUntil(const LoginRoute(), predicate: (r) => false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure navigating the user to the login route is the right path here. If they are deleting their account Im guessing its more likely they don't want an account rather than they want to log into a different one. I could be wrong though... (e.g. maybe if the user wanted to change email or something but I think we can offer a different flow for that)
If you think that's right then we should probably leave them on the more menu page but have some kind of notification to show that the delete was successful... We might need to chat to design folks about that though.
appRouter: AutoRouter.of(context), | ||
userService: locator<UserService>(), | ||
), | ||
child: BlocBuilder<DeleteAccountBloc, DeleteAccountState>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More of a question, but is it generally better to have the bloc builders lower down in the tree (e.g. only wrapping the submit button and input) or is this ok? I assume the latter is better as it results in less re rendering but basically irrelevant for a page as simple as this but more generally is a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I recon so, I'm used to Android Compose way where only changed things are rebuilt, fixed thanks!
7f5d6a0
to
395c4e5
Compare
08c843d
to
69da324
Compare
f4441a8
to
24b5dfa
Compare
bcc67ab
to
c6cd9c3
Compare
Description
Please include a brief summary of what the issue is and what has been done to solve it
Fixes #<issue_number> or taiga link
Checklist:
Creator
Reviewer
After pull