Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show dialog when completing action but not logged in #302

Merged
merged 3 commits into from
Aug 11, 2024

Conversation

JElgar
Copy link
Member

@JElgar JElgar commented Aug 6, 2024

Description

Currently when the user is not logged in we show them buttons on the action info page which they can click to complete the action. If they click that button they get a 403.
Instead this updates the button to show a dialog saying they need to login.
It also updates to login to take an "inititalRoute" parameter. This can be used to set the route which should be navigated to after login (or skip) is complete.
This is used in the action flow so that the user is returned to the same action page after logging in

Fixes #291

Checklist:

Creator

  • The target branch is main
  • I have updated the unreleased section of the change log
  • I have reviewed the 'files changed' tab on github to ensure all changes are as expected
  • I have added someone to review the pr

Reviewer

  • I have verified the above are all completed
  • I have run the code locally to ensure it fufills the requirements of the issue
  • I have reviewed the 'files changed' and commented on any sections which I think are not needed, incorrect or could be improved

After pull

  • If appropriate I have closed the issue/ moved the trello card

@JElgar JElgar requested a review from kackogut August 6, 2024 13:58
@JElgar JElgar force-pushed the complete-action-no-auth branch 3 times, most recently from cf4be1d to b1285e9 Compare August 6, 2024 14:20
@JElgar JElgar force-pushed the complete-action-no-auth branch 2 times, most recently from b951d8e to 8c78b7a Compare August 6, 2024 14:45
@JElgar JElgar force-pushed the complete-action-no-auth branch from 8c78b7a to c6787c8 Compare August 6, 2024 14:46
@JElgar JElgar merged commit c7442c8 into main Aug 11, 2024
2 checks passed
@JElgar JElgar deleted the complete-action-no-auth branch August 11, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

We show complete action button when not logged in and we try to complete learning resources as well
2 participants