Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forms to use now-u domain #356

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update forms to use now-u domain #356

merged 1 commit into from
Nov 18, 2024

Conversation

JElgar
Copy link
Member

@JElgar JElgar commented Nov 18, 2024

Description

Please include a brief summary of what the issue is and what has been done to solve it

Fixes #<issue_number> or taiga link

Checklist:

Creator

  • The target branch is main
  • I have updated the unreleased section of the change log
  • I have reviewed the 'files changed' tab on github to ensure all changes are as expected
  • I have added someone to review the pr

Reviewer

  • I have verified the above are all completed
  • I have run the code locally to ensure it fufills the requirements of the issue
  • I have reviewed the 'files changed' and commented on any sections which I think are not needed, incorrect or could be improved

After pull

  • If appropriate I have closed the issue/ moved the trello card

@JElgar JElgar requested a review from kackogut November 18, 2024 18:03
final JOIN_RESEARCH_FORM_URI = Uri.parse('https://forms.gle/DjSdjH1DfNtRwXiP7');
final FEEDBACK_FORM_URI = Uri.parse('https://www.now-u.com/app/feedback');
final JOIN_RESEARCH_FORM_URI = Uri.parse(
'https://www.now-u.com/app/research/signup',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe either we can stick to trailing comma like here, or remove it, like value above? i think I'm voting for the second one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was the original plan but then the linter shouted at me and tried to do the thing where it puts the assignment on the line after: 5ab93ff
I was thinking of making the above match the latter but I think if we can fit on one line it probably makes sense? Maybe I should have just accepts darts insistence on having assignments on the line after

@JElgar JElgar merged commit 8929f25 into main Nov 18, 2024
2 checks passed
@JElgar JElgar deleted the forms branch November 18, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants