Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:npm install does not detect engine-compatible package properly #7825

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

kchindam-infy
Copy link

The fix addresses an issue where the engine-strict flag is not enforced during the version resolution phase in npm. When engine-strict is enabled, npm should only install package versions that are compatible with the current Node.js version, as specified in the package's engines field. However, prior to this fix, npm did not consider the engines.node field during version resolution, potentially leading to the installation of incompatible package versions.

Enforces engine-strict During Version Resolution:
Modifies the build-ideal-tree.js file to ensure that when engine-strict is enabled, npm filters out package versions that are incompatible with the current Node.js version before selecting which version to install.

References

@kchindam-infy kchindam-infy requested a review from a team as a code owner October 9, 2024 18:00
@wraithgar
Copy link
Member

This behavior belongs in pacote. It's already doing a lot of logic to pick the right manifest based on the spec. If fact it may actually be npm-pick-manifest that needs to be fixed here. https://github.com/npm/pacote/blob/35529738b00143a05d61ad361d30a7ea26c87bed/lib/registry.js#L130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants