Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 5.1 #584

Closed
wants to merge 1 commit into from
Closed

Add support for Django 5.1 #584

wants to merge 1 commit into from

Conversation

nrbnlulu
Copy link
Owner

@nrbnlulu nrbnlulu commented Nov 25, 2024

This PR adds support for Django 5.1:

  • Update Django version range to include 5.1
  • Update CI configuration to test with Django 5.1

Note: Python 3.13 support has been postponed until strawberry-graphql adds support for it.

Summary by Sourcery

Add support for Django 5.1 by updating the version range in the project dependencies and adjusting the CI configuration to test against this new version.

New Features:

  • Add support for Django 5.1 by updating the version range in the project dependencies.

CI:

  • Update CI configuration to include testing with Django 5.1.

- Add Django 5.1 support
- Remove Python 3.13 support for now (waiting for strawberry-graphql compatibility)
- Update CI configuration to test with Django 5.1
Copy link

sourcery-ai bot commented Nov 25, 2024

Reviewer's Guide by Sourcery

This PR implements Django 5.1 support by updating version constraints in the project configuration and adjusting the CI workflow. The changes primarily involve modifying version ranges and test matrix configurations while maintaining backward compatibility.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update Django version compatibility range
  • Extend Django version upper bound from <5.1 to <5.2
  • Remove deprecated types-pkg-resources dependency
pyproject.toml
Expand CI test matrix to include Django 5.1
  • Add Django 5.1 to the test matrix
  • Add exclusion rules for Python 3.8 and 3.9 with Django 5.1
  • Update test matrix compatibility comments
.github/workflows/tests.yml
Update Python version support in black configuration
  • Add Python 3.11 and 3.12 to black target versions
pyproject.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nrbnlulu - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you explain why types-pkg-resources was removed? Is it no longer needed?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@nrbnlulu nrbnlulu closed this Nov 26, 2024
@nrbnlulu nrbnlulu deleted the feature/django-5.1 branch December 10, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants