Explicitly specifying FileShare.Read attribute when opening log stream #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is strange that such basic API like This change should not break compatibility for .NET Framework / .NET Core / NET6-9. |
|
Do you plan to release the Nuget soon, which would include this PR? |
|
@zoka-cz sorry, I accedentally missed your question! Already shipped in 1.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the library on iPhone (Xamarin) it appears, that the mention in #65
is not true for iPhone. When opening the file for read, which is currently in use by
FileLoggerit throws the sharing violation. With this pull request it does not.I believe that this PR does not break anything else as FileShare.Read should be default option in other than iOS implementation.