Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index: map each release with compatible nrf-sdk version #43

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

FilipZajdel
Copy link
Contributor

@FilipZajdel FilipZajdel commented Apr 30, 2024

VSC-2567

Changes:

  • From now on each add-on release is accompanied with the nRF Connect SDK revision it is compatible with. This removes the compatibleNcs array previously utilized for representing similar relationship.
  • Each release needs to be manually announced in the Add-ons index by modifying particular customer's index file.

From now on each add-on release is accompanied with the
nRF Connect SDK revision it is compatible with. This removes
the `compatibleNcs` array previously utilized for representing
similar relationship.
Each release needs to be manually announced in the Add-ons index
by modifying particular customer's index file.

Signed-off-by: FilipZajdel <[email protected]>
@FilipZajdel FilipZajdel requested review from greg-fer and bencefr April 30, 2024 13:29
bencefr
bencefr previously approved these changes Jun 4, 2024
Copy link

@bencefr bencefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my minor comments the change looks alright, although there's a conflicting request already from Golioth. Please comment or suggest on their PR to smoothen the ride.

site/src/schema.ts Show resolved Hide resolved
site/src/app/ReleasesDropDownList.tsx Outdated Show resolved Hide resolved
index/circuitdojo.json Show resolved Hide resolved
Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add v to SDK releases.

@bencefr bencefr self-requested a review June 5, 2024 06:41
@FilipZajdel
Copy link
Contributor Author

FilipZajdel commented Jun 5, 2024

@greg-fer can you have a look at the descriptions I have just added to the schema, please?

@FilipZajdel FilipZajdel added this pull request to the merge queue Jun 5, 2024
Merged via the queue into main with commit dcd4e84 Jun 5, 2024
3 checks passed
@FilipZajdel FilipZajdel deleted the sdk-version branch November 13, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants