Add support for random MAC address #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioannisg
approved these changes
Dec 5, 2024
Add a build time option to generate random MAC address, this helps in test deployments. Used Zephyr API in the BM code to simplify things, as srand() was giving same MAC address (seed problems). Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
add_random_mac
branch
from
f11733a to
5622bc8
Compare
Done, added a separate section. |
This build path isn't tested, fix build errors. Signed-off-by: Chaitanya Tata <[email protected]>
Group them logically for a better navigation and reading experience. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
add_random_mac
branch
from
5622bc8 to
88d8682
Compare
Add for both RPU context and FMAC context. Signed-off-by: Chaitanya Tata <[email protected]>
ioannisg
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Thanks! @sachinthegreen pls, review the code part as well :)
MAC address can be passed to init which takes precedence over any build time options. Signed-off-by: Chaitanya Tata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a build time option to generate random MAC address, this helps in test deployments.
Used Zephyr API in the BM code to simplify things, as srand() was giving same MAC address (seed problems).