Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mode specific APIs #40

Merged

Conversation

sachinthegreen
Copy link
Contributor

Update the nrf70 Wi-Fi driver to use mode specific APIs (as a precursor to enable combining modes as required).

@sachinthegreen sachinthegreen force-pushed the nrf70-system-radiotest branch 4 times, most recently from 2476275 to 06886c0 Compare January 31, 2025 11:32
@sachinthegreen sachinthegreen force-pushed the nrf70-system-radiotest branch 3 times, most recently from a7e059c to 4eef3d1 Compare February 6, 2025 18:38
Copy link
Contributor

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments only @sachinthegreen

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
source "Kconfig.zephyr"
endmenu

module = NR70_SCAN_RT_BM_SAMPLE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why the nomenclature does not include COMBO or COMBINED and just lists the two modes, _SCAN_RT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific reason :). Felt that having both scan and RT in the name implied combined.

samples/scan_rt_bm/src/main.c Outdated Show resolved Hide resolved
@ioannisg
Copy link
Contributor

ioannisg commented Feb 6, 2025

@sachinthegreen @krish2718 , not urgent to do on this PR, but I think we need to lightly enhance the architecture documentation to state the modes of operation and the new added capability to run-time switch between the two modes.
MAybe add a "supported modes" section in the docs and explain it there.

We can do it after this pr is merged.

@sachinthegreen sachinthegreen force-pushed the nrf70-system-radiotest branch 2 times, most recently from f63215e to 62585c9 Compare February 7, 2025 10:34
Kulkarni and others added 4 commits February 7, 2025 18:48
Update the nrf70 Wi-Fi driver to use mode specific
APIs (as a precursor to enable combining modes as required).
Separate out mode specific code into mode specific files for
ease of readability and maintenance. This also acts as a
precursor to be able to combine modes into a single build.
Changes to enable combining system and radio test code in a
single build.

Signed-off-by: Sachin D Kulkarni <[email protected]>
Add sample to demonstrate runtime switching between scan and
radio test modes of operation for nRF70.

Signed-off-by: Sachin D Kulkarni <[email protected]>
Documentation changes for scan and radio test combo mode
operation.

Signed-off-by: Sachin D Kulkarni <[email protected]>
@sachinthegreen sachinthegreen merged commit 180f5e5 into nrfconnect:main Feb 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants