-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf fromtree] app: clusters: Add handling a local lock operation error #332
[nrf fromtree] app: clusters: Add handling a local lock operation error #332
Conversation
4d1e30d
to
9259a9a
Compare
9259a9a
to
7efd83c
Compare
Strange, I thought this had been addressed in the Matter upstream. |
Should be, but actually isn't. I didn't find another way to handle it, only the remote operation is handled within the Lock server and the SendLockOperationEvent method is private so I guess it shouldn't be used outside the Lock server. We can upstream it also if you want, or don't do anything until it is addressed in Matter upstream. I see, thanks for the clarification. I suggest we should upstream this patch as you mentioned. Maybe someone from the community will explain the current implementation state during review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend upstreaming this change, unless we are sure we can remember about it during upmerging :)
Why this is targeted only to v2.4-branch?
We need it only for FELL purposes for now, and this project includes the v2.4-branch. I will upstream those changes and we will have it in the sdk-connectedhomeip main branch later. |
…-server (#29857) The current implementation of the door-lock server supports emitting the LockOperationEvent only if the credential has been provided remotely. In case we use a custom handling lock credential in the application code the event is emitted only on the correct credential, but we also need a mechanism that allows the door lock server to handle a lock operation error when the wrong credential has been provided. Added handling local lock operation error to emit LockOperationEvent and call HandleWrongCodeEntry. cherry-picked from b9d525e
7efd83c
to
58b4a55
Compare
In case we use a custom handling lock credential we need a mechanism that allows us to handle a lock operation error when the wrong credential has been provided.
Added handling local lock operation error to emit LockOperationEvent and call HandleWrongCodeEntry.