[nrf fromlist] Clear endpoint bitmask before reporting the PartList attribute #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArekBalysNordic
requested review from
LuDuda,
kkasperczyk-no and
markaj-nordic
ArekBalysNordic
force-pushed
the
endpoint_bitmask
branch
from
6257498 to
dab0cfa
Compare
LuDuda
approved these changes
Oct 11, 2023
ArekBalysNordic
force-pushed
the
endpoint_bitmask
branch
from
8a7ac6c to
4990d46
Compare
…ttribute When we set a low value to the minimum subscription interval for subscription for the PartList attribute of the Description cluster, and then remove a dynamic endpoint the related bitmask may change after reporting it to a controller. The controller receives the old number of endpoints and does not update it within the following subscriptions until the next change of the PartList attribute occurs. To resolve the issue the endpoint bitmask should be cleared before reporting the PartList attribute of the Descriptor cluster to avoid race conditions. [nrf] -> There is an old API and there is bitmask operation instead of the method Clear!
ArekBalysNordic
force-pushed
the
endpoint_bitmask
branch
from
4990d46 to
524099b
Compare
kkasperczyk-no
approved these changes
Oct 12, 2023
Currently, in the Matter 1.1.0.1 revision, there is a problem in the reporting engine that causes wrong logic with marking mutated change paths to send the report later. In the SetDirty method, we called handler->setDirty before calling the InsertPathIntoDirtySet method which caused the report not to be sent properly because there was no new attribute to be sent on the DirtySet and the generation version was forgotten, so the next data report did not contain an update. It occurs when the controller sets too low value for a minimal subscription interval and the device tries to send a report scheduled to be sent immediately after the event occurs without waiting to Inserting a path to the DirtySet. This issue seems to be repaired in the Matter 1.2 revision, so we can provide a workaround, and then revert/remove that PR during the next synchronization with Matter SDK.
ArekBalysNordic
force-pushed
the
endpoint_bitmask
branch
from
524099b to
b7f3a0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we set a low value to the minimum subscription interval for subscription for the PartList attribute of the Description cluster, and then remove a dynamic endpoint the related bitmask may change after reporting it to a controller.
The controller receives the old number of endpoints and does not update it within the following subscriptions until the next change of the PartList attribute occurs.
To resolve the issue the endpoint bitmask should be cleared before reporting the PartList attribute of the Descriptor cluster to avoid race conditions.
[nrf] -> There is an old API and there is a bitmask operation instead of the method Clear!