[nrf fromlist] [nrfconnect] Add a delay to last fabric remove action #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArekBalysNordic
requested review from
LuDuda,
kkasperczyk-no and
markaj-nordic
LuDuda
reviewed
Oct 16, 2023
examples/platform/nrfconnect/util/include/FabricTableDelegate.h
Outdated
Show resolved
Hide resolved
kkasperczyk-no
approved these changes
Oct 17, 2023
ArekBalysNordic
force-pushed
the
fabric_removal_fix
branch
from
724804a to
8750c3f
Compare
In some cases, a last fabric removal action should be delayed to avoid race conditions and allow the device to finish all currently running tasks. To control the delay use the CONFIG_CHIP_LAST_FABRIC_REMOVED_SCHEDULE_TIME kconfig. By default it has been set to 500 ms.
ArekBalysNordic
force-pushed
the
fabric_removal_fix
branch
from
8750c3f to
1dffeb4
Compare
kkasperczyk-no
approved these changes
Oct 18, 2023
github-actions
bot
added
the
documentation
LuDuda
approved these changes
Oct 18, 2023
examples/platform/nrfconnect/util/include/FabricTableDelegate.h
Outdated
Show resolved
Hide resolved
The factory data documentation contains the wrong example of the factory data script invocation and it did not allow users to use it.
ArekBalysNordic
force-pushed
the
fabric_removal_fix
branch
from
baa4e13 to
7d76d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, a last fabric removal action should be delayed to avoid race conditions and allow the device to finish all currently running tasks.
To control the delay use the
CONFIG_CHIP_LAST_FABRIC_REMOVED_SCHEDULE_TIME kconfig. By default, it has been set to 500 ms.