LTO build fixes #339
Merged
LTO build fixes #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damian-Nordic
force-pushed
the
lto-fixes
branch
2 times, most recently
from
f3edecc to
f2dffc6
Compare
LuDuda
reviewed
Oct 24, 2023
There was a problem hiding this comment.
This is awesome! Thank you 👍
I would like to merge the changes needed to enable LTO, but would like to either (ideally) have KConfig option to enable LTO for Matter, or alternatively not adding -flto flags now yet - those will be added for generic CONFIG_LTO soon.
Damian-Nordic
force-pushed
the
lto-fixes
branch
from
f2dffc6 to
2173686
Compare
|
@LuDuda The commit to enable LTO was added just for testing. I removed it, so the PR can be merged now. |
kkasperczyk-no
approved these changes
Oct 26, 2023
Fix the build of Matter samples with sys_heap malloc enabled. The linker errors would occur because: 1. The realloc() function is not used outside the LTO- optimized code. 2. Thus, the LTO linker plugin would mark __wrap_realloc symbol as PREVAILING_DEF_IRONLY, which would enable the compiler to optimize away the function. 3. As a result, undefined references to realloc() could not be resolved by the linker. Mark malloc/calloc/realloc/free as externally visible. Signed-off-by: Damian Krolik <[email protected]>
libCHIPShell.a is already part of libCHIP.a but the former had to be linked additionally with --whole-archive flag to process the shell and init objects defined with SHELL_XXX and SYS_INIT Zephyr macros and, in turn, register Matter shell commands properly. This symbol duplication between the two libraries causes issues when building Matter with LTO, so replace the current approach with explicitly pulling in one symbol from MainLoopZephyr.cpp file. Signed-off-by: Damian Krolik <[email protected]>
Damian-Nordic
force-pushed
the
lto-fixes
branch
from
2173686 to
95c9783
Compare
markaj-nordic
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Zephyr] Fix sys_heap malloc build with LTO
[nrfconnect] Do not link libCHIPShell.a with --whole-archive