[nrf noup] wifi: avoid unwanted connect request #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArekBalysNordic
approved these changes
Dec 8, 2023
kkasperczyk-no
approved these changes
Dec 8, 2023
It's pointless to issue a connect request in case no valid SSID has been found. Signed-off-by: Marcin Kajor <[email protected]>
markaj-nordic
force-pushed
the
2.5.1-fix-wifi-unexpected-connect
branch
from
03d1385 to
fffa71c
Compare
LuDuda
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pointless to issue a connect request in case no valid SSID has been found.
I may cause the commissioning to fail when the SSID is not found at the first try, because without the
returnwe go on and end up with the Connect() call that does not make sense and triggers a callback that deceptively informs Matter controller that the WiFiNetworkEnable commissioning step failed.