[nrf toup] Reduce Packet Buffer Pool size to 11 #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2024
Damian-Nordic
approved these changes
Nov 5, 2024
| @@ -48,7 +48,7 @@ struct ChipDeviceEvent; | |||
| #define CHIP_SYSTEM_CONFIG_USE_SOCKETS 1 | |||
|
|
|||
| #ifndef CONFIG_ARCH_POSIX | |||
| #define CHIP_SYSTEM_CONFIG_PACKETBUFFER_POOL_SIZE 15 | |||
| #define CHIP_SYSTEM_CONFIG_PACKETBUFFER_POOL_SIZE 11 | |||
There was a problem hiding this comment.
Is this selected based on the top usage in tests?
There was a problem hiding this comment.
Also, please fill in this info in the commit description :)
There was a problem hiding this comment.
As this is not yet targeted for 2.8.0 and we have a bit of time - what do you think to introduce a KConfig for this configuration?
There was a problem hiding this comment.
As this is not yet targeted for 2.8.0 and we have a bit of time - what do you think to introduce a KConfig for this configuration?
Good idea.
Is this selected based on the top usage in tests?
Yes, highest observed pool usage was 10. I updated commit description.
adigie
force-pushed
the
optimize-memory-usage
branch
from
5f3a9cb to
94ebf53
Compare
adigie
force-pushed
the
optimize-memory-usage
branch
from
94ebf53 to
fc8dc9b
Compare
ArekBalysNordic
approved these changes
Dec 12, 2024
Add `CHIP_SYSTEM_PACKETBUFFER_POOL_SIZE` Kconfig for packet buffer pool size configuration. Signed-off-by: Adrian Gielniewski <[email protected]> [nrf toup] config: Reduce packet buffer pool size to 11 Value selected based on top usage in tests. Highest observed number of packet buffers was 10. Signed-off-by: Adrian Gielniewski <[email protected]>
adigie
force-pushed
the
optimize-memory-usage
branch
from
fc8dc9b to
61a07ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.