[nrf toup][Zephyr] Retry starting BLE advertising after releasing con… #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArekBalysNordic
force-pushed
the
fix_ble_arbiter
branch
from
ff23e97 to
d2b67d8
Compare
ArekBalysNordic
force-pushed
the
fix_ble_arbiter
branch
from
d2b67d8 to
11805a9
Compare
ArekBalysNordic
force-pushed
the
fix_ble_arbiter
branch
4 times, most recently
from
9979e02 to
28649af
Compare
…nection. In Zephyr 4.0, the BT_LE_ADV_OPT_CONNECTABLE and BT_LE_ADV_OPT_CONNECTABLE advertising options have been deprecated and we need to use BT_LE_ADV_OPT_CONN instead. Due to the fact that the automatic advertiser resumption is deprecated, we must ensure that the BLE advertising arbiter restarts advertising in a different way if the service could not be started, for example, due to an existing BLE connection, or connection has been closed. We can use the recycled callback of the BT_CONN_CB to check if there is pending request in the list and if so, try to restart advertising. Signed-off-by: Arkadiusz Balys <[email protected]>
ArekBalysNordic
force-pushed
the
fix_ble_arbiter
branch
from
28649af to
56f3874
Compare
Damian-Nordic
approved these changes
Feb 27, 2025
| .recycled = | ||
| []() { | ||
| // In this callback the connection object was returned to the pool and we can try to re-start connectable | ||
| // advertising, but only if the disconnection was detected. |
There was a problem hiding this comment.
Just curious - in which cases where the connection is recycled we don't want to retry the advertising?
There was a problem hiding this comment.
This callback is called not only if the disconnection occurs, but on every action that the conn object is released. So, in the case of ChipOverBLE advertising, this callback has been called many times, but actually, there is no need to retry advertising. They deprecated auto-restart on disconnection, so we should take into account only calls if a disconnect occurs to keep previous functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nection.
In Zephyr 4.0, the BT_LE_ADV_OPT_CONNECTABLE and
BT_LE_ADV_OPT_CONNECTABLE advertising options have been deprecated and we need to use BT_LE_ADV_OPT_CONN instead.
Due to the fact that the automatic advertiser resumption is deprecated, we must ensure that the BLE advertising arbiter
restarts advertising in a different way if the service could not be started, for example, due to an existing BLE connection, or the connection has been closed.
We can use the recycled callback of the BT_CONN_CB to check if there is pending request in the list, and if so, try to restart advertising.