mpsl: make mpsl sw interrupt kconfig configurable #13362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
Tschet1
force-pushed
the
make_sw_interrupt_kconfig_configurable
branch
5 times, most recently
from
c200a41 to
11b9e47
Compare
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
jori-nordic
reviewed
Dec 12, 2023
subsys/mpsl/init/Kconfig
Outdated
| @@ -56,6 +56,14 @@ config MPSL_TRIGGER_IPC_TASK_ON_RTC_START_CHANNEL | |||
| The application core part of the code needs to be aware of | |||
| which channel is used. | |||
|
|
|||
| config MPSL_LOW_PRIO_IRQN | |||
| int | |||
| default $(dt_node_array_prop_int,$(dt_nodelabel_path,swi5),interrupts,0) if SOC_COMPATIBLE_NRF52X | |||
There was a problem hiding this comment.
discussed OOB: I suggest to drop the dts complexity and "just hardcode" the number.
When we do have to revisit this, I propose we do the right thing (IMO) and add a mpsl driver and configure the SWI through a property.
Tschet1
force-pushed
the
make_sw_interrupt_kconfig_configurable
branch
from
11b9e47 to
de71998
Compare
jori-nordic
approved these changes
Dec 12, 2023
rugeGerritsen
approved these changes
Dec 12, 2023
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
Tschet1
force-pushed
the
make_sw_interrupt_kconfig_configurable
branch
2 times, most recently
from
376ab37 to
c6ca011
Compare
Make the SW interrupt that MPSL is using configurable through KConfig. Like that, MPSL can better cooperate with other libraries that might use the same SW interrupt. Signed-off-by: Jan Müller <[email protected]>
Update the MPSL documentation in nrfxlib. Signed-off-by: Jan Müller <[email protected]>
Tschet1
force-pushed
the
make_sw_interrupt_kconfig_configurable
branch
from
c6ca011 to
7d68f5a
Compare
Tschet1
removed
the
changelog-entry-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the SW interrupt that MPSL is using configurable through KConfig. Like that, MPSL can better cooperate with other libraries that might use the same SW interrupt.