Samples: Bluetooth: Checking return value of functions #16807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martintv
requested review from
alwa-nordic,
jori-nordic,
carlescufi and
KAGA164
as code owners
github-actions
bot
added
the
changelog-entry-required
alwa-nordic
reviewed
Aug 8, 2024
martintv
force-pushed
the
fixing_central_uart_gatt_assert
branch
from
ca4028d to
02f3623
Compare
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
martintv
force-pushed
the
fixing_central_uart_gatt_assert
branch
2 times, most recently
from
5e42645 to
1c30d74
Compare
alwa-nordic
approved these changes
Aug 8, 2024
jori-nordic
approved these changes
Aug 12, 2024
KAGA164
reviewed
Aug 12, 2024
| bt_nus_subscribe_receive(nus); | ||
| err = bt_nus_handles_assign(dm, nus); | ||
| if (err) { | ||
| LOG_INF("bt_nus_handles_assign failed with errorcode %i", err); |
There was a problem hiding this comment.
Suggested change
| LOG_INF("bt_nus_handles_assign failed with errorcode %i", err); | |
| LOG_INF("bt_nus_handles_assign failed (err %d)", err); |
|
|
||
| err = bt_nus_subscribe_receive(nus); | ||
| if (err) { | ||
| LOG_INF("bt_nus_subscribe_receive failed with errorcode %i", err); |
There was a problem hiding this comment.
Suggested change
| LOG_INF("bt_nus_subscribe_receive failed with errorcode %i", err); | |
| LOG_INF("bt_nus_subscribe_receive failed (err %d)", err); |
Just for cohesion with the rest of sample logs
Without this, an assert in gatt.c:5350 could happen. It happened when the link got disconnected during service discovery procedure. Signed-off-by: Martin Tverdal <[email protected]>
martintv
force-pushed
the
fixing_central_uart_gatt_assert
branch
from
1c30d74 to
98b5dd7
Compare
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 98b5dd71f840963d6b979b2b14e8413d82082ee4 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: 3dd8985b56 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
KAGA164
approved these changes
Aug 12, 2024
|
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, an assert in gatt.c:5350 could happen, when bt_nus_subscribe_receive called bt_gatt_subscribe. It happened when the link got disconnected during
service discovery procedure.
I was debugging something else, and I simulated very bad rf-conditions to trigger this assert.
Callstack when assert triggered
