samples: ssf_client: support sysbuild and remove sdfw_update service from sample #17239

anhmolt · 2024-09-09T12:07:39Z

app+rad multi image build
remove call to sdfw_update service
Clean up sample.yaml and log by default on default serial

NordicBuilder · 2024-09-09T12:14:30Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 5c3e01425727bb950c45d25cb841f026d540f743

more details

sdk-nrf:

PR head: 5c3e01425727bb950c45d25cb841f026d540f743
merge base: d05aa8982166ac45a26773ff6e403109f8a38e29
target head (main): d05aa8982166ac45a26773ff6e403109f8a38e29
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (17)

samples
│  ├── sdfw
│  │  ├── ssf_client
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── README.rst
│  │  │  ├── boards
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  │ nrf54h20dk_nrf54h20_cpurad.overlay
│  │  │  ├── prj.conf
│  │  │  ├── rad_image
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54h20dk_nrf54h20_cpurad.overlay
│  │  │  │  │  ├── nrf9280pdk_nrf9280_cpurad.conf
│  │  │  │  │  │ nrf9280pdk_nrf9280_cpurad.overlay
│  │  │  │  │ prj.conf
│  │  │  ├── sample.yaml
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  │  ├── sysbuild.cmake
│  │  │  │ uart_logging.conf

Outputs:

Toolchain

Version: add720b6d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:add720b6d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 40
✅ Integration tests
- ⚠️ test-secdom-samples-public

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_cloud
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-09-09T13:11:31Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

nordicjm · 2024-10-08T11:37:31Z

multi-image build is child/parent image, this should say sysbuild

anhmolt · 2024-10-08T11:41:49Z

multi-image build is child/parent image, this should say sysbuild

Thanks! Have updated the title.

nordicjm · 2024-10-28T11:21:57Z

samples/sdfw/ssf_client/Kconfig.sysbuild

+config RADIO_IMAGE_BOARD
+	string "The board used for cpurad target"
+	depends on BUILD_ALSO_FOR_RADIO_CORE
+	default "nrf54h20dk/nrf54h20/cpurad" if BOARD_NRF54H20DK_NRF54H20_CPUAPP
+	default "nrf9280pdk/nrf9280/cpurad" if BOARD_NRF9280PDK_NRF9280_CPUAPP


Rework to work as the sysbuild Kconfig files do i.e. rename to *_BOARD_TARGET_CPUCLUSTER, reference SOC_* Kconfigs and only have the CPU cluster here then work out the board to use properly in cmake - see https://github.com/nrfconnect/sdk-nrf/blob/main/sysbuild/Kconfig.netcore#L15 and https://github.com/nrfconnect/sdk-nrf/blob/main/sysbuild/netcore.cmake

Thanks. I have updated to work out the radio board target in cmake.

Enable logging by default. Signed-off-by: Andreas Moltumyr <[email protected]>

Remove deprecated sdfw_update service request from the sample. Signed-off-by: Andreas Moltumyr <[email protected]>

Use CONFIG_BOARD_TARGET instead of CONFIG_BOARD in the sample log message and echo string. Signed-off-by: Andreas Moltumyr <[email protected]>

Build additional radio image when building for application CPU and CONFIG_SB_ALSO_FOR_RADIO_CORE is set. Signed-off-by: Andreas Moltumyr <[email protected]>

nordicjm · 2024-10-29T09:16:55Z

samples/sdfw/ssf_client/Kconfig.sysbuild

+source "${ZEPHYR_BASE}/share/sysbuild/Kconfig"
+
+config BUILD_ALSO_FOR_RADIO_CORE
+	bool "Build also for the radio CPU"


this should have depends on for what needs it and default y

nordicjm · 2024-10-29T09:17:36Z

samples/sdfw/ssf_client/sample.yaml

+    extra_args:
+      SB_CONFIG_BUILD_ALSO_FOR_RADIO_CORE=y


and this should not be present

nordicjm · 2024-10-29T09:18:14Z

samples/sdfw/ssf_client/sysbuild.cmake

+string(REPLACE "/" ";" split_board_qualifiers "${BOARD_QUALIFIERS}")
+list(GET split_board_qualifiers 1 target_soc)
+list(GET split_board_qualifiers 2 target_cpucluster)
+set(board_target_radiocore "${BOARD}/${target_soc}/${SB_CONFIG_RADIO_BOARD_TARGET_CPUCLUSTER}")
+set(target_soc)
+set(target_cpucluster)


this goes in the if() part below

github-actions · 2024-12-01T00:42:15Z

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

anhmolt requested review from hakonfam, jonathannilsen and 9gcity September 9, 2024 12:07

github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Sep 9, 2024

anhmolt force-pushed the sample-ssf_client-log-default branch from de72335 to a064f67 Compare September 9, 2024 12:30

anhmolt force-pushed the sample-ssf_client-log-default branch from a064f67 to fa53678 Compare October 8, 2024 11:26

anhmolt requested review from a team as code owners October 8, 2024 11:26

anhmolt changed the title ~~samples: ssf_client: support multi-image build and remove sdfw_update service from sample~~ samples: ssf_client: support sysbuild and remove sdfw_update service from sample Oct 8, 2024

FrancescoSer approved these changes Oct 14, 2024

View reviewed changes

nordicjm requested changes Oct 28, 2024

View reviewed changes

anhmolt added 4 commits October 29, 2024 10:01

samples: sdfw: ssf_client: enable logging for default build

9fb49d0

Enable logging by default. Signed-off-by: Andreas Moltumyr <[email protected]>

samples: sdfw: ssf_client: remove deprecated sdfw_update service req

931f9a3

Remove deprecated sdfw_update service request from the sample. Signed-off-by: Andreas Moltumyr <[email protected]>

samples: sdfw: ssf_client: use CONFIG_BOARD_TARGET in prints

3fea714

Use CONFIG_BOARD_TARGET instead of CONFIG_BOARD in the sample log message and echo string. Signed-off-by: Andreas Moltumyr <[email protected]>

samples: sdfw: ssf_client: support for building app+rad using sysbuild

5c3e014

Build additional radio image when building for application CPU and CONFIG_SB_ALSO_FOR_RADIO_CORE is set. Signed-off-by: Andreas Moltumyr <[email protected]>

anhmolt force-pushed the sample-ssf_client-log-default branch from fa53678 to 5c3e014 Compare October 29, 2024 09:01

anhmolt requested a review from a team as a code owner October 29, 2024 09:01

jonathannilsen approved these changes Oct 29, 2024

View reviewed changes

nordicjm reviewed Oct 29, 2024

View reviewed changes

FrancescoSer approved these changes Oct 29, 2024

View reviewed changes

github-actions bot added the Stale label Dec 1, 2024

thst-nordic closed this Dec 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples: ssf_client: support sysbuild and remove sdfw_update service from sample #17239

samples: ssf_client: support sysbuild and remove sdfw_update service from sample #17239

anhmolt commented Sep 9, 2024

NordicBuilder commented Sep 9, 2024 •

edited

Loading

NordicBuilder commented Sep 9, 2024

nordicjm commented Oct 8, 2024

anhmolt commented Oct 8, 2024

nordicjm Oct 28, 2024

anhmolt Oct 29, 2024

nordicjm Oct 29, 2024

nordicjm Oct 29, 2024

nordicjm Oct 29, 2024

github-actions bot commented Dec 1, 2024

samples: ssf_client: support sysbuild and remove sdfw_update service from sample #17239

samples: ssf_client: support sysbuild and remove sdfw_update service from sample #17239

Conversation

anhmolt commented Sep 9, 2024

NordicBuilder commented Sep 9, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

NordicBuilder commented Sep 9, 2024

nordicjm commented Oct 8, 2024

anhmolt commented Oct 8, 2024

nordicjm Oct 28, 2024

Choose a reason for hiding this comment

anhmolt Oct 29, 2024

Choose a reason for hiding this comment

nordicjm Oct 29, 2024

Choose a reason for hiding this comment

nordicjm Oct 29, 2024

Choose a reason for hiding this comment

nordicjm Oct 29, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 1, 2024

NordicBuilder commented Sep 9, 2024 •

edited

Loading