Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: do not select NRF_MODEM_LIB #17366

Closed
wants to merge 2 commits into from

Conversation

lemrey
Copy link
Contributor

@lemrey lemrey commented Sep 18, 2024

libmodem is enabled automatically for all nRF9 projects.
Using select to express a dependency is bad practice, and should be avoided in favour of depends on.

I will add more commits-- just checking what changes I need in each to keep things building.
edit: I may need one commit to change lots of stuff to untangle dependency loops.

@lemrey lemrey requested a review from rlubos as a code owner September 18, 2024 07:57
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 18, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Sep 18, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: a79912921dec0f192c675a9bed1c598712f561c3

more details

sdk-nrf:

PR head: a79912921dec0f192c675a9bed1c598712f561c3
merge base: cfb2a11d013959f2fa68a1dc9460a1cf1c6fda82
target head (main): cfb2a11d013959f2fa68a1dc9460a1cf1c6fda82
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (5)
lib
│  ├── modem_info
│  │  │ Kconfig
│  ├── modem_jwt
│  │  │ Kconfig
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  │ Kconfig.nrf_cloud_fota
│  │  │  ├── nrf_provisioning
│  │  │  │  ├── Kconfig
│  │  │  │  │ Kconfig.nrf_provisioning_codec

Outputs:

Toolchain

Version: 2aae60c2f9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:2aae60c2f9_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 328
  • ◻️ Integration tests
    • ◻️ test-fw-nrfconnect-nrf-iot_cloud
    • ◻️ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ◻️ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ◻️ test-fw-nrfconnect-nrf-iot_thingy91
    • ◻️ test-fw-nrfconnect-nrf-iot_mosh
    • ◻️ test-fw-nrfconnect-nrf-iot_positioning
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

libmodem is enabled automatically for all nRF9 projects.
Using `select` to express a dependency is bad practice,
and should be avoided in favour of `depends on`.

Signed-off-by: Emanuele Di Santo <[email protected]>
Do not imply NRF_MODEM_LIB, instead depend on it.
It is enabled by default in all nRF9 projects.

Signed-off-by: Emanuele Di Santo <[email protected]>
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@trantanen
Copy link
Contributor

Is there a plan to take this forward?

@lemrey lemrey added the DNM label Oct 17, 2024
Copy link

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants