-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: do not select NRF_MODEM_LIB #17366
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: a79912921dec0f192c675a9bed1c598712f561c3 more detailssdk-nrf:
Github labels
List of changed files detected by CI (5)
Outputs:ToolchainVersion: 2aae60c2f9 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
053c63d
to
5ea5263
Compare
libmodem is enabled automatically for all nRF9 projects. Using `select` to express a dependency is bad practice, and should be avoided in favour of `depends on`. Signed-off-by: Emanuele Di Santo <[email protected]>
Do not imply NRF_MODEM_LIB, instead depend on it. It is enabled by default in all nRF9 projects. Signed-off-by: Emanuele Di Santo <[email protected]>
5ea5263
to
a799129
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
Is there a plan to take this forward? |
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
libmodem is enabled automatically for all nRF9 projects.
Using
select
to express a dependency is bad practice, and should be avoided in favour ofdepends on
.I will add more commits-- just checking what changes I need in each to keep things building.
edit: I may need one commit to change lots of stuff to untangle dependency loops.