Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: sdk-connectedhomeip: Fix reliability issues with multicasts #17633

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

LuDuda
Copy link
Contributor

@LuDuda LuDuda commented Oct 3, 2024

This commit updates the Matter SDK revision to include fixes that improve the reliability of multicast message delivery by enabling MLDv2 reporting.

Btw. After this is merged i do plan to backport the fix to NCS 2.6 and 2.7 branches as well.

@LuDuda LuDuda added the bugfix Fixes a known bug label Oct 3, 2024
@LuDuda LuDuda added this to the 2.8.0 milestone Oct 3, 2024
@LuDuda LuDuda requested review from a team as code owners October 3, 2024 20:29
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 3, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 3, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@973259c (master) nrfconnect/sdk-connectedhomeip#486 nrfconnect/sdk-connectedhomeip#486/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 3, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 4e878b8774345eb17cf490c51e21a77dd5ef470e

more details

sdk-nrf:

PR head: 4e878b8774345eb17cf490c51e21a77dd5ef470e
merge base: ffebf6fa21a08c88f35ac88cc10b76f6576a9f8d
target head (main): d09f74119fa044ad65d2327cec09de59aa02d7d5
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  │ known_issues.rst

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

doc/nrf/releases_and_maturity/known_issues.rst Outdated Show resolved Hide resolved
doc/nrf/releases_and_maturity/known_issues.rst Outdated Show resolved Hide resolved
doc/nrf/releases_and_maturity/known_issues.rst Outdated Show resolved Hide resolved
@divipillai divipillai removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 8, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 9, 2024
@LuDuda LuDuda requested a review from wiba-nordic October 9, 2024 18:52
@wiba-nordic wiba-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 10, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 11, 2024
This commit updates the Matter SDK revision to include fixes that
improve the reliability of multicast message delivery by enabling MLDv2
reporting.

Signed-off-by: Łukasz Duda <[email protected]>
@rlubos rlubos merged commit fd10013 into nrfconnect:main Oct 11, 2024
13 of 14 checks passed
Matter over Wi-Fi devices only subscribed to multicast addresses within the internal IPv6 stack, without notifying the Access Points, leading to reliability issues with multicast message delivery.

**Workaround:** To ensure reliable multicast communication, use the :c:func:`net_ipv6_mld_join` and :c:func:`net_ipv6_mld_leave` functions to explicitly subscribe or unsubscribe to multicast addresses.
For reference, see the commit with the fix in the ``sdk-connectedhomeip`` repository (commit hash: ``TBD``).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the hash was not updated before merging to 08acaf44604acef6679bd7eb2d6b51245bcfa54c. Will file a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval. manifest-matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants