Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk-mcuboot: Fix compressed chunk size mismatch #18199

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

nordicjm
Copy link
Contributor

No description provided.

Synchronises this value to the existing MCUboot chunk size as the
MCUboot value has been set to mirror this value

Signed-off-by: Jamie McCrae <[email protected]>
@nordicjm nordicjm requested review from a team as code owners October 25, 2024 10:41
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 25, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 25, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
mcuboot nrfconnect/[email protected] nrfconnect/sdk-mcuboot@0a70e49 (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@nordicjm nordicjm added this to the 2.8.0 milestone Oct 25, 2024
@nordicjm nordicjm added the backport v2.8-branch auto-create a PR with same commits to v2.8-branch label Oct 25, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 25, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 8d2e6d516d25ee929b77aff7aa0447059d7c54f2
mcuboot: PR head: 0a70e4968d1f65118a2b5a17a27ed990c296bb5f

more details

sdk-nrf:

PR head: 8d2e6d516d25ee929b77aff7aa0447059d7c54f2
merge base: 74ec8d27eb9ac759e32080753dc883fd82402159
target head (main): 932fa5da615c04b92d13ca9d3a7582c207eb06cb
Diff

mcuboot:

PR head: 0a70e4968d1f65118a2b5a17a27ed990c296bb5f
merge base: 0ab75e06ed7ce5ffc7b2790dfa2756180cb04abf
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
bootloader
│  ├── mcuboot
│  │  ├── .github
│  │  │  ├── workflows
│  │  │  │  │ backport.yml
│  │  ├── boot
│  │  │  ├── zephyr
│  │  │  │  │ Kconfig
subsys
│  ├── nrf_compress
│  │  │ Kconfig
west.yml

Outputs:

Toolchain

Version: add720b6d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:add720b6d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 474
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-sdk-mcuboot
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Copy link
Contributor

@gchwier gchwier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested manually the quarantined tests: nrf_compress.decompression.mcuboot_update
on platforma nrf5340 and nrf54l15, now it works

@nordicjm nordicjm removed the backport v2.8-branch auto-create a PR with same commits to v2.8-branch label Oct 28, 2024
Fixes an issue with decompression caused by a buffer size not
matching the nRF compression chunk size

Signed-off-by: Jamie McCrae <[email protected]>
@NordicBuilder NordicBuilder removed the DNM label Oct 28, 2024
@nordicjm nordicjm merged commit a8c6c1a into nrfconnect:main Oct 29, 2024
13 of 14 checks passed
@nordicjm nordicjm deleted the fixcompchunksize branch November 6, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-mcuboot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants