samples: nrf5340: remove deprecated multiprotocol_rpmsg #19372

ankuns · 2024-12-10T10:17:44Z

The multiprotocol_rpmsg sample for the nrf5340 is removed. The functionality is taken over by the ipc_radio application.

ticket: KRKNWK-19770

ankuns · 2024-12-10T10:18:54Z

@robertstypa please guide here what to do with:
modules/lib/suit-generator/ncs/root_with_nordic_top_envelope.yaml.jinja2
line 13

{%- elif multiprotocol_rpmsg_subimage is defined %}
  {% set rad = multiprotocol_rpmsg_subimage %}

ankuns · 2024-12-10T10:20:11Z

@kkasperczyk-no please guide what to do with:

modules/lib/matter/config/zephyr/chip-module/Kconfig.multiprotocol_rpmsg.defaults
modules/lib/matter/config/zephyr/chip-module/Kconfig.multiprotocol_rpmsg.root
File names contain multiprotocol_rpmsg, as well as occurences of multiprotocol_rpmsg inside these files

doc/nrf/protocols/matter/getting_started/hw_requirements.rst
Occurences of multiprotocol_rpmsg in memory sizes
Update: covered by commit b35ada0

NordicBuilder · 2024-12-10T10:22:31Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 17

Inputs:

Sources:

sdk-nrf: PR head: 340f8277d1871fcdd86f6f5008e8e8a1761ef8a0
nrfxlib: PR head: 7a9b76c051f55fb2afe81d10b49c5434d10e6fb3

more details

sdk-nrf:

PR head: 340f8277d1871fcdd86f6f5008e8e8a1761ef8a0
merge base: a0fa60254f1b693921e2499aa9615bc97d305acb
target head (main): dee077dd8a7deedcd9bcc9e2af3dff0483903b03
Diff

nrfxlib:

PR head: 7a9b76c051f55fb2afe81d10b49c5434d10e6fb3
merge base: 92d0783d41d53926231423b4ff9b0df534a0fa50
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (28)

.github
│  │ test-spec.yml
CODEOWNERS
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── config_and_build
│  │  │  │  ├── sysbuild
│  │  │  │  │  ├── sysbuild_images.rst
│  │  │  │  │  │ zephyr_samples_sysbuild.rst
│  │  │  ├── device_guides
│  │  │  │  ├── nrf53
│  │  │  │  │  ├── building_nrf53.rst
│  │  │  │  │  ├── features_nrf53.rst
│  │  │  │  │  │ multi_image_nrf5340.rst
│  │  ├── protocols
│  │  │  ├── matter
│  │  │  │  ├── getting_started
│  │  │  │  │  ├── hw_requirements.rst
│  │  │  │  │  │ transmission_power.rst
│  │  ├── releases_and_maturity
│  │  │  ├── migration
│  │  │  │  ├── migration_guide_2.7.rst
│  │  │  │  │ migration_sysbuild.rst
│  │  │  ├── releases
│  │  │  │  ├── release-notes-1.5.0.rst
│  │  │  │  ├── release-notes-2.2.0.rst
│  │  │  │  ├── release-notes-2.7.0.rst
│  │  │  │  │ release-notes-changelog.rst
nrfxlib
│  ├── nrf_802154
│  │  ├── doc
│  │  │  │ rd_limitations.rst
samples
│  ├── CMakeLists.txt
│  ├── Kconfig
│  ├── matter
│  │  ├── light_bulb
│  │  │  │ sample.yaml
│  ├── nrf5340
│  │  ├── multiprotocol_rpmsg
│  │  │  ├── CMakeLists.txt
│  │  │  ├── README.rst
│  │  │  ├── prj.conf
│  │  │  ├── sample.yaml
│  │  │  ├── src
│  │  │  │  │ main.c
scripts
│  ├── ci
│  │  │ tags.yaml
│  │ memory-threshold-list.yaml
sysbuild
│  │ Kconfig.netcore
west.yml

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 16
✅ Integration tests
- ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
- ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_mesh
- ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ doc-internal - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_nrf_provisioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ps - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run

Note: This message is automatically posted and updated by the CI

peknis · 2024-12-10T10:31:35Z

Changelog entry required. If not two of them, one under the Samples/nRF5340 samples saying that the Multiprotocol RPMsg sample has been removed and maybe another in the Documentation section.

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

NordicBuilder · 2024-12-10T12:38:28Z

Memory footprint analysis revealed the following potential issues

sample.matter.template.release[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 820674[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 911846[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-19372/13)

NordicBuilder · 2024-12-11T10:37:44Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
nrfxlib	nrfconnect/sdk-nrfxlib@`92d0783`	nrfconnect/sdk-nrfxlib@`7a9b76c` (`main`)	nrfconnect/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-12-11T10:55:21Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

The `multiprotocol_rpmsg` sample for the nrf5340 is removed. The functionality is taken over by the `ipc_radio` application. Signed-off-by: Andrzej Kuros <[email protected]>

The samples/nrf5340/multiprotocol_rpmsg is removed. Add changelog entry. Signed-off-by: Andrzej Kuros <[email protected]>

Replaced obsolete multiprotocol_rpmsg and hci_ipc names with ipc_radio. Signed-off-by: Kamil Kasperczyk <[email protected]>

The samples/nrf5340/multiprotocol_rpmsg sample is removed. References to it in historical files are changed to text ``nRF5340: Multiprotocol RPMsg``. Signed-off-by: Andrzej Kuros <[email protected]>

ankuns requested review from a team, nordic-piks, PerMac, katgiadla and hubertmis as code owners December 10, 2024 10:17

github-actions bot added the doc-required PR must not be merged without tech writer approval. label Dec 10, 2024

hubertmis approved these changes Dec 10, 2024

View reviewed changes

nordic-piks approved these changes Dec 10, 2024

View reviewed changes

ankuns force-pushed the remove_sample_nrf5340_multiprotocol_rpmsg branch from 5fd8621 to a2c51d5 Compare December 10, 2024 10:42

greg-fer approved these changes Dec 10, 2024

View reviewed changes

peknis requested changes Dec 10, 2024

View reviewed changes

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst Outdated Show resolved Hide resolved

nordicjm approved these changes Dec 10, 2024

View reviewed changes

mariusz-nordicsemi approved these changes Dec 10, 2024

View reviewed changes

kkasperczyk-no approved these changes Dec 11, 2024

View reviewed changes

ankuns force-pushed the remove_sample_nrf5340_multiprotocol_rpmsg branch from e352a64 to b1a2a22 Compare December 11, 2024 10:36

github-actions bot added the manifest label Dec 11, 2024

NordicBuilder added the manifest-nrfxlib label Dec 11, 2024

NordicBuilder added the DNM label Dec 11, 2024

peknis approved these changes Dec 11, 2024

View reviewed changes

umapraseeda approved these changes Dec 11, 2024

View reviewed changes

ankuns force-pushed the remove_sample_nrf5340_multiprotocol_rpmsg branch 4 times, most recently from 77c6619 to 9ddf3e3 Compare December 18, 2024 16:07

ankuns and others added 4 commits December 19, 2024 16:20

samples: nrf5340: remove deprecated multiprotocol_rpmsg

9a8b430

The `multiprotocol_rpmsg` sample for the nrf5340 is removed. The functionality is taken over by the `ipc_radio` application. Signed-off-by: Andrzej Kuros <[email protected]>

samples: nrf5340: changelog for multiprotocol_rpmsg removal

240ec0b

The samples/nrf5340/multiprotocol_rpmsg is removed. Add changelog entry. Signed-off-by: Andrzej Kuros <[email protected]>

doc: Updated hw_requirements for Matter

5ec5c94

Replaced obsolete multiprotocol_rpmsg and hci_ipc names with ipc_radio. Signed-off-by: Kamil Kasperczyk <[email protected]>

doc: remove references to removed sample nRF5340: Multiprotocol RPMsg

340f827

The samples/nrf5340/multiprotocol_rpmsg sample is removed. References to it in historical files are changed to text ``nRF5340: Multiprotocol RPMsg``. Signed-off-by: Andrzej Kuros <[email protected]>

ankuns force-pushed the remove_sample_nrf5340_multiprotocol_rpmsg branch from 9ddf3e3 to 340f827 Compare December 19, 2024 15:21

NordicBuilder removed the DNM label Dec 19, 2024

rlubos merged commit 31d1fa5 into nrfconnect:main Dec 20, 2024
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples: nrf5340: remove deprecated multiprotocol_rpmsg #19372

samples: nrf5340: remove deprecated multiprotocol_rpmsg #19372

ankuns commented Dec 10, 2024 •

edited

Loading

ankuns commented Dec 10, 2024

ankuns commented Dec 10, 2024 •

edited

Loading

NordicBuilder commented Dec 10, 2024 •

edited

Loading

peknis commented Dec 10, 2024

NordicBuilder commented Dec 10, 2024 •

edited

Loading

NordicBuilder commented Dec 11, 2024 •

edited

Loading

NordicBuilder commented Dec 11, 2024

samples: nrf5340: remove deprecated multiprotocol_rpmsg #19372

samples: nrf5340: remove deprecated multiprotocol_rpmsg #19372

Conversation

ankuns commented Dec 10, 2024 • edited Loading

ankuns commented Dec 10, 2024

ankuns commented Dec 10, 2024 • edited Loading

NordicBuilder commented Dec 10, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

peknis commented Dec 10, 2024

NordicBuilder commented Dec 10, 2024 • edited Loading

Memory footprint analysis revealed the following potential issues

NordicBuilder commented Dec 11, 2024 • edited Loading

NordicBuilder commented Dec 11, 2024

ankuns commented Dec 10, 2024 •

edited

Loading

ankuns commented Dec 10, 2024 •

edited

Loading

NordicBuilder commented Dec 10, 2024 •

edited

Loading

NordicBuilder commented Dec 10, 2024 •

edited

Loading

NordicBuilder commented Dec 11, 2024 •

edited

Loading