nrf_modem_lib: lte_net_if: query actual link MTU #19537

JordanYates · 2024-12-15T07:48:34Z

Update the network interface MTU before raising the connectivity event, so that the MTU as queried by downstream users is correct, instead of an assumed value based on IPv6 required minimums.

NordicBuilder · 2024-12-15T07:48:53Z

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

NordicBuilder · 2024-12-15T08:07:17Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

eivindj-nordic

Thank you for your contribution.
We would also need a changelog entry for this in https://github.com/nrfconnect/sdk-nrf/blob/main/doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst#modem-libraries

lib/nrf_modem_lib/lte_net_if/lte_net_if.c

divipillai · 2024-12-16T10:05:00Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

@@ -443,7 +443,7 @@ Security libraries
 Modem libraries
 ---------------

-|no_changes_yet_note|
+* :ref:`nrf_modem_lib_lte_net_if` now automatically sets the actual link MTU on the network interface when PDN connectivity is gained.


Suggested change

* :ref:`nrf_modem_lib_lte_net_if` now automatically sets the actual link MTU on the network interface when PDN connectivity is gained.

* :ref:`nrf_modem_lib_readme`:

Updated the :ref:`nrf_modem_lib_lte_net_if` to automatically set the actual link :term:`Maximum Transmission Unit (MTU)` on the network interface when PDN connectivity is gained.

NordicBuilder · 2024-12-16T12:46:39Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 614788d558895a039fd94f6c6d1311a034e09793

more details

sdk-nrf:

PR head: 614788d558895a039fd94f6c6d1311a034e09793
merge base: ef172cdb46c29326938e19c3f7cd99f5af3187e4
target head (main): ef172cdb46c29326938e19c3f7cd99f5af3187e4
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (4)

doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
lib
│  ├── nrf_modem_lib
│  │  ├── lte_net_if
│  │  │  │ lte_net_if.c
│  │  │ nrf9x_sockets.c
tests
│  ├── lib
│  │  ├── nrf_modem_lib
│  │  │  ├── lte_net_if
│  │  │  │  ├── src
│  │  │  │  │  │ main.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 443
✅ Integration tests
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_samples
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m
- ✅ test-fw-nrfconnect-nrf-iot_mosh
- ⚠️ test-fw-nrfconnect-nrf-iot_cloud

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

eivindj-nordic · 2024-12-18T18:12:09Z

@JordanYates Tests are failing for modem lib lte_net_if (https://github.com/nrfconnect/sdk-nrf/tree/main/tests/lib/nrf_modem_lib/lte_net_if) Please have a look. You can run the tests locally to see what is failing:

west build -b native_sim -p
west flash

eivindj-nordic · 2024-12-19T08:34:38Z

tests/lib/nrf_modem_lib/lte_net_if/src/main.c

@@ -411,6 +411,13 @@ void test_pdn_act_without_cereg_should_not_activate_iface(void)
 	TEST_ASSERT_TRUE(net_if_is_dormant(net_if));
 }

+static int pdn_mtu_1000(uint8_t cid, struct in_addr *dns4_pri,


Please place the stub at the top of the file

Suggested change

static int pdn_mtu_1000(uint8_t cid, struct in_addr *dns4_pri,

static int pdn_dynamic_params_get_stub_mtu_1000(uint8_t cid, struct in_addr *dns4_pri,

eivindj-nordic · 2024-12-19T11:56:24Z

@JordanYates This needs to be rebased on main before it can be merged.

Update the network interface MTU before raising the connectivity event, so that the MTU as queried by downstream users is correct, instead of an assumed value based on IPv6 required minimums. Signed-off-by: Jordan Yates <[email protected]>

Test the behaviour of the network interface under the three conditions: 1. MTU successfully queried 2. Function reports success but MTU not set 3. Function reports error Signed-off-by: Jordan Yates <[email protected]>

eivindj-nordic · 2025-01-10T08:41:24Z

@JordanYates Changes have been made to the PDN library and the pdn_dynamic_params_get() function is deprecated and replaced by the pdn_dynamic_info_get() function.
See #19701 for details.

JordanYates requested review from a team as code owners December 15, 2024 07:48

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 15, 2024

NordicBuilder added the external External contribution label Dec 15, 2024

eivindj-nordic reviewed Dec 16, 2024

View reviewed changes

lib/nrf_modem_lib/lte_net_if/lte_net_if.c Outdated Show resolved Hide resolved

JordanYates force-pushed the lte_if_mtu branch from 8a58c00 to 651dfd4 Compare December 16, 2024 09:59

JordanYates requested a review from a team as a code owner December 16, 2024 09:59

github-actions bot added doc-required PR must not be merged without tech writer approval. and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Dec 16, 2024

JordanYates requested a review from eivindj-nordic December 16, 2024 09:59

divipillai reviewed Dec 16, 2024

View reviewed changes

JordanYates force-pushed the lte_if_mtu branch from 651dfd4 to 94871ce Compare December 16, 2024 11:10

eivindj-nordic added CI-Requested Approves single commit for CI tests on Internal HW and removed CI-Requested Approves single commit for CI tests on Internal HW labels Dec 16, 2024

github-actions bot removed the CI-Requested Approves single commit for CI tests on Internal HW label Dec 18, 2024

eivindj-nordic added the CI-Requested Approves single commit for CI tests on Internal HW label Dec 19, 2024

eivindj-nordic reviewed Dec 19, 2024

View reviewed changes

eivindj-nordic requested a review from divipillai December 19, 2024 08:35

divipillai approved these changes Dec 19, 2024

View reviewed changes

JordanYates force-pushed the lte_if_mtu branch from c7a989a to ab04739 Compare December 19, 2024 11:39

github-actions bot removed the CI-Requested Approves single commit for CI tests on Internal HW label Dec 19, 2024

eivindj-nordic approved these changes Dec 19, 2024

View reviewed changes

eivindj-nordic added the CI-Requested Approves single commit for CI tests on Internal HW label Dec 19, 2024

tests: nrf_modem_lib: lte_net_if: test MTU behaviour

614788d

Test the behaviour of the network interface under the three conditions: 1. MTU successfully queried 2. Function reports success but MTU not set 3. Function reports error Signed-off-by: Jordan Yates <[email protected]>

JordanYates force-pushed the lte_if_mtu branch from ab04739 to 614788d Compare December 19, 2024 12:37

github-actions bot removed the CI-Requested Approves single commit for CI tests on Internal HW label Dec 19, 2024

eivindj-nordic added the CI-Requested Approves single commit for CI tests on Internal HW label Dec 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nrf_modem_lib: lte_net_if: query actual link MTU #19537

nrf_modem_lib: lte_net_if: query actual link MTU #19537

JordanYates commented Dec 15, 2024

NordicBuilder commented Dec 15, 2024

NordicBuilder commented Dec 15, 2024

eivindj-nordic left a comment

divipillai Dec 16, 2024

NordicBuilder commented Dec 16, 2024 •

edited

Loading

eivindj-nordic commented Dec 18, 2024 •

edited

Loading

eivindj-nordic Dec 19, 2024

eivindj-nordic commented Dec 19, 2024

eivindj-nordic commented Jan 10, 2025

-* :ref:`nrf_modem_lib_lte_net_if` now automatically sets the actual link MTU on the network interface when PDN connectivity is gained.
+* :ref:`nrf_modem_lib_readme`:
+  Updated the :ref:`nrf_modem_lib_lte_net_if` to automatically set the actual link :term:`Maximum Transmission Unit (MTU)` on the network interface when PDN connectivity is gained.

	static int pdn_mtu_1000(uint8_t cid, struct in_addr *dns4_pri,
	static int pdn_dynamic_params_get_stub_mtu_1000(uint8_t cid, struct in_addr *dns4_pri,

nrf_modem_lib: lte_net_if: query actual link MTU #19537

Are you sure you want to change the base?

nrf_modem_lib: lte_net_if: query actual link MTU #19537

Conversation

JordanYates commented Dec 15, 2024

NordicBuilder commented Dec 15, 2024

NordicBuilder commented Dec 15, 2024

eivindj-nordic left a comment

Choose a reason for hiding this comment

divipillai Dec 16, 2024

Choose a reason for hiding this comment

NordicBuilder commented Dec 16, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

eivindj-nordic commented Dec 18, 2024 • edited Loading

eivindj-nordic Dec 19, 2024

Choose a reason for hiding this comment

eivindj-nordic commented Dec 19, 2024

eivindj-nordic commented Jan 10, 2025

NordicBuilder commented Dec 16, 2024 •

edited

Loading

eivindj-nordic commented Dec 18, 2024 •

edited

Loading