Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: Fix missing OTA requestor device type. #19543

Merged

Conversation

ArekBalysNordic
Copy link
Contributor

According to Matter 1.4 certification IDM-10.5 test case the device should contain OTA requestor device type on endpoint 0.

In all Matter samples there is no such as device type. We need to fix it to pass the certification test case.

ref: KRKNWK-19804

@ArekBalysNordic ArekBalysNordic added the bugfix Fixes a known bug label Dec 16, 2024
@ArekBalysNordic ArekBalysNordic requested review from a team as code owners December 16, 2024 08:45
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 16, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 16, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 94a920cd5eaf88d8faa45d0484f586edba7009ba

more details

sdk-nrf:

PR head: 94a920cd5eaf88d8faa45d0484f586edba7009ba
merge base: 29e854691257829a156250d7fa5321f1dbc76073
target head (main): 29e854691257829a156250d7fa5321f1dbc76073
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (25)
applications
│  ├── matter_bridge
│  │  ├── snippets
│  │  │  ├── onoff_plug
│  │  │  │  ├── bridge.zap
│  │  │  │  ├── zap-generated
│  │  │  │  │  │ endpoint_config.h
│  │  ├── src
│  │  │  ├── default_zap
│  │  │  │  ├── bridge.zap
│  │  │  │  ├── zap-generated
│  │  │  │  │  │ endpoint_config.h
│  ├── matter_weather_station
│  │  ├── src
│  │  │  ├── default_zap
│  │  │  │  ├── weather-station.zap
│  │  │  │  ├── zap-generated
│  │  │  │  │  │ endpoint_config.h
samples
│  ├── matter
│  │  ├── light_bulb
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── light_bulb.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  │ endpoint_config.h
│  │  ├── light_switch
│  │  │  ├── snippets
│  │  │  │  ├── lit_icd
│  │  │  │  │  ├── light_switch.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  │ endpoint_config.h
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── light_switch.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  │ endpoint_config.h
│  │  ├── lock
│  │  │  ├── snippets
│  │  │  │  ├── schedules
│  │  │  │  │  ├── lock.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  │ endpoint_config.h
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── lock.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  │ endpoint_config.h
│  │  ├── smoke_co_alarm
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── smoke_co_alarm.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  ├── IMClusterCommandHandler.cpp
│  │  │  │  │  │  │ endpoint_config.h
│  │  ├── template
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── template.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  │ endpoint_config.h
│  │  ├── thermostat
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── thermostat.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  │ endpoint_config.h
│  │  ├── window_covering
│  │  │  ├── src
│  │  │  │  ├── default_zap
│  │  │  │  │  ├── window-app.zap
│  │  │  │  │  ├── zap-generated
│  │  │  │  │  │  │ endpoint_config.h

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 137
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-chip
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

According to Matter 1.4 certification IDM-10.5 test case the
device should contain OTA requestor device type on endpoint 0.

In all Matter samples there is no such as device type.
We need to fix it to pass the certification test case.

Signed-off-by: Arkadiusz Balys <[email protected]>
@ArekBalysNordic ArekBalysNordic merged commit 9d1b151 into nrfconnect:main Dec 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants