suit: Align cpuapp partitions to new memory map #19607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
tomchy
requested review from
SylwesterKonczyk,
robertstypa,
ahasztag,
adsz-nordic and
kszromek-nordic
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 56551a9abc578827d7ccf8abb46bbccd77fbb1d5 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
robertstypa
approved these changes
Dec 18, 2024
adsz-nordic
approved these changes
Dec 18, 2024
tomchy
force-pushed
the
bugfix/suit/NCSDK-NONE_Align_smp_transfer_partitions
branch
2 times, most recently
from
c02e395 to
b90e973
Compare
| @@ -35,11 +38,11 @@ | |||
| #size-cells = < 0x1 >; | |||
|
|
|||
| /delete-node/ partition@54000; | |||
| cpurad_slot0_partition: partition@66000 { | |||
| reg = < 0x66000 DT_SIZE_K(160) >; | |||
| cpurad_slot0_partition: partition@54000 { | |||
There was a problem hiding this comment.
I think recovery partition should be located below main partition (to decrease a risk of overwrite)
| cpuapp_recovery_partition: partition@a5000 { | ||
| reg = <0xa5000 DT_SIZE_K(84)>; | ||
| cpuapp_recovery_partition: partition@94000 { | ||
| reg = <0x94000 DT_SIZE_K(84)>; | ||
| }; |
There was a problem hiding this comment.
no cpuapp_recovery_rfu_partition?
Align smp_transfer partitions, as proposed in: nrfconnect#19044 Ref: NCSDK-NONE Signed-off-by: Tomasz Chyrowicz <[email protected]>
tomchy
force-pushed
the
bugfix/suit/NCSDK-NONE_Align_smp_transfer_partitions
branch
from
b90e973 to
56551a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align smp_transfer partitions, as proposed in:
#19044
Ref: NCSDK-NONE