sample: tfm_psa_template: Print attestation pubkey #19657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 66a7efce348c63c495131ed8b97c791babaec564 more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
hellesvik-nordic
force-pushed
the
attestation_sample_print_pubkey
branch
from
702de1b to
6c28e28
Compare
tomi-font
reviewed
Dec 19, 2024
hellesvik-nordic
force-pushed
the
attestation_sample_print_pubkey
branch
from
6c28e28 to
a64143a
Compare
tomi-font
approved these changes
Dec 19, 2024
Vge0rge
reviewed
Dec 19, 2024
| psa_key_attributes_t attr = PSA_KEY_ATTRIBUTES_INIT; | ||
|
|
||
| status = psa_get_key_attributes(key_handle, &attr); | ||
| if (status != 0) { |
There was a problem hiding this comment.
lets use PSA_SUCCESS here instead of hard code 0.
| @@ -145,6 +177,7 @@ static void get_attestation_token(void) | |||
| } else { | |||
| printk("Received initial attestation token of %zu bytes.\n", token_size); | |||
|
|
|||
| printf("Attestation token:\n"); | |||
There was a problem hiding this comment.
Nit but replace all the printf->printk to be consistent across the sample.
Print the public key for attestation, which can be used for verifying the attestation token. Ref: NCSDK-31111 Signed-off-by: Sigurd Hellesvik <[email protected]>
hellesvik-nordic
force-pushed
the
attestation_sample_print_pubkey
branch
from
a64143a to
66a7efc
Compare
Vge0rge
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print the public key for attestation, which can be used for verifying the attestation token.
Ref: NCSDK-31111