boards: thingy91x: fix swapped blue/green LEDs #19667
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping for blue and green LEDs has been swapped for both
leds
andpwmleds
nodes to correctly control the desired color.Issue
From the LED table on the Thingy91x hardware documentation we expect the following LED mappings:
However we can see from the current board mapping that blue and green are reversed.
sdk-nrf/boards/nordic/thingy91x/thingy91x_nrf9151_common.dts
Lines 29 to 43 in 84ec4da
Reproducing the issue
Verify that the blue and green LEDs are reversed by running the zephyr/samples/basic/blinky application with the following patch:
Correcting pwmleds
I could not find any documentation on the hardware page or in the available schematic for how the PWM channels should be mapped. However, when comparing the Thingy91 to the Thingy91x, pwmleds for green and blue are swapped in the same way described above. This PR also corrects this.