Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: nrf_desktop: Support passthrough reports in hid state #19690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pdunaj
Copy link
Contributor

@pdunaj pdunaj commented Dec 20, 2024

Allow the hid state module to handle reports created by external modules. These reports will still be sent according to the his state rules.

@pdunaj pdunaj requested a review from MarekPieta December 20, 2024 13:41
@pdunaj pdunaj requested review from a team as code owners December 20, 2024 13:41
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 20, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 20, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: 4a866a47bbf8efad882045926fa84d8573d10e33

more details

sdk-nrf:

PR head: 4a866a47bbf8efad882045926fa84d8573d10e33
merge base: 3665a25025dcfb35f78b1d383fc37444d8618037
target head (main): 4e9061784c3eb9297cd1f83256f6289f3c4846c7
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
applications
│  ├── nrf_desktop
│  │  ├── configuration
│  │  │  ├── common
│  │  │  │  │ hid_report_desc.h
│  │  ├── src
│  │  │  ├── modules
│  │  │  │  ├── Kconfig.hid_state
│  │  │  │  ├── hid_state.c
│  │  │  │  │ usb_state.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 92
  • ✅ Integration tests
    • ✅ desktop52_verification
Disabled integration tests
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@pdunaj
Copy link
Contributor Author

pdunaj commented Dec 20, 2024

why @nrfconnect/ncs-co-build-system is needed for review of app specific kconfig?
@carlescufi , can it be fixed for our apps or is this some global setting on all kconfigs?

@nordicjm
Copy link
Contributor

why @nrfconnect/ncs-co-build-system is needed for review of app specific kconfig? @carlescufi , can it be fixed for our apps or is this some global setting on all kconfigs?

Because of the amount of abuse and wrong things in Kconfigs all over the tree that have improved substantially now things are actually reviewed and issues pointed out

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

Allow the hid state module to handle reports created by external
modules.
These reports will still be sent according to the his state rules.

Signed-off-by: Pawel Dunaj <[email protected]>
@pdunaj
Copy link
Contributor Author

pdunaj commented Dec 20, 2024

Appease pedantic checkpatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants