-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: matter: Refactor nRF54H20 partition in samples #19735
base: main
Are you sure you want to change the base?
samples: matter: Refactor nRF54H20 partition in samples #19735
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 426104d221903b3f9977cbbb3931c4fcc7de7323 more detailssdk-nrf:
Github labels
List of changed files detected by CI (16)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Memory footprint analysis revealed the following potential issuessample.matter.template.debug[nrf7002dk/nrf5340/cpuapp]: High ROM usage: 911938[B] - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-19735/4) |
c68920b
to
1831f2a
Compare
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
- Refactored nRF54H20 partitions to support storing Nordic-related SoC binaries in external flash. - Enabled storing Nordic SoC binaries in the external flash if the SUIT_ENVELOPE_NORDIC_TOP_DIRECTORY kconfig value is provided. Signed-off-by: Arkadiusz Balys <[email protected]>
1831f2a
to
a147c26
Compare
Described SUIT DFU process in Matter samples which can be performed on nRF54H20 modules. Currently only Matter OTA protocol is fully supported. Signed-off-by: Arkadiusz Balys <[email protected]>
a147c26
to
426104d
Compare
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
@nrfconnect/ncs-charon, @nrfconnect/ncs-charon-doc and @nrfconnect/ncs-co-build-system could you please review related changes? |
if SOC_SERIES_NRF54HX | ||
|
||
config SUIT_ENVELOPE | ||
default y | ||
|
||
config SUIT_BUILD_FLASH_COMPANION | ||
default y | ||
|
||
config SUIT_MULTI_IMAGE_PACKAGE_BUILD | ||
default y if MATTER_OTA | ||
|
||
config SUIT_BASE_MANIFEST_VARIANT | ||
default "matter/v1" | ||
|
||
endif | ||
config SUIT_ENVELOPE_NORDIC_TOP_EXTRACT_PAYLOADS_TO_CACHE | ||
default y if SUIT_ENVELOPE_NORDIC_TOP_DIRECTORY != "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not be abusing Kconfig files as thought they are defconfig files. If these are needed then the symbols should depend on them, or select them if the known issues are adhered to properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I would like to set the SUIT_ENVELOPE_NORDIC_TOP_EXTRACT_PAYLOADS_TO_CACHE
if the user provides a path to the top directory using SUIT_ENVELOPE_NORDIC_TOP_DIRECTORY
. Currently in Kconfig.suit
SUIT_ENVELOPE_NORDIC_TOP_EXTRACT_PAYLOADS_TO_CACHE
depends on SUIT_ENVELOPE_NORDIC_TOP_IN_ROOT
and SUIT_ENVELOPE_NORDIC_TOP_IN_ROOT
is default y
if SUIT_ENVELOPE_NORDIC_TOP_DIRECTORY != "". I don't understand the abuse here, which kconfig of all mentioned should select or have dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nordicjm what do you recommend in this case?
SoC binaries in external flash.
the SUIT_ENVELOPE_NORDIC_TOP_DIRECTORY kconfig value is provided.
on nRF54H20 modules. Currently, only the Matter OTA protocol is fully supported.