applications: nrf5340_audio: LED module for kits with other LED setup #20483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 238384ffe16279bb78e2e04b75cf16dea2321cda more detailssdk-nrf:
Github labels
List of changed files detected by CI (24)Outputs:ToolchainVersion: 4cff34261a Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
nordicjm
reviewed
Feb 19, 2025
| @@ -0,0 +1,39 @@ | |||
| /* | |||
There was a problem hiding this comment.
commit message is indented when it should not be
nordicjm
requested changes
Feb 19, 2025
| <&gpio0 26 GPIO_ACTIVE_HIGH>; | ||
| label = "RGB LED 0"; | ||
| }; | ||
| rgb2: rgb-2 { |
There was a problem hiding this comment.
line spacing between child nodes
| psels = <NRF_PSEL(I2S_MCK, 0, 12)>; | ||
| nordic,drive-mode = <NRF_DRIVE_H0H1>; | ||
| }; | ||
| group2 { |
| /** @brief List of buttons and associated metadata | ||
| */ | ||
| enum button_pin_names { | ||
| BUTTON_VOLUME_DOWN = DT_GPIO_PIN(DT_ALIAS(sw0), gpios), | ||
| BUTTON_VOLUME_UP = DT_GPIO_PIN(DT_ALIAS(sw1), gpios), | ||
| BUTTON_PLAY_PAUSE = DT_GPIO_PIN(DT_ALIAS(sw2), gpios), | ||
| #if defined(CONFIG_BOARD_NRF5340_AUDIO_DK_NRF5340_CPUAPP) |
There was a problem hiding this comment.
use DT macros to check if node exists
| @@ -52,6 +52,7 @@ const static struct btn_config btn_cfg[] = { | |||
| .btn_pin = BUTTON_PLAY_PAUSE, | |||
| .btn_cfg_mask = DT_GPIO_FLAGS(DT_ALIAS(sw2), gpios), | |||
| }, | |||
| #if defined(CONFIG_BOARD_NRF5340_AUDIO_DK_NRF5340_CPUAPP) | |||
|
|
||
| #include <zephyr/logging/log.h> | ||
| LOG_MODULE_REGISTER(led, CONFIG_MODULE_LED_LOG_LEVEL); | ||
| LOG_MODULE_REGISTER(led, 4); /* CONFIG_MODULE_LED_LOG_LEVEL); */ |
| @@ -8,8 +8,8 @@ target_sources(app PRIVATE | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/channel_assignment.c | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/error_handler.c | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/uicr.c | |||
| ${CMAKE_CURRENT_SOURCE_DIR}/board_init.c | |||
| * | ||
| * @return 0 if successful, error otherwise. | ||
| */ | ||
| int board_init(void); |
There was a problem hiding this comment.
do not name function with board_* likewise with Kconfigs, that is reserved for actual boards files in the boards folder not applications
Comment on lines
+7
to
+8
| #ifndef _BOARD_H_ | ||
| #define _BOARD_H_ |
gWacey
force-pushed
the
OCT-3012-LED-module-for-kits-with-other-LED-setup
branch
from
cc4d61d to
7fb59b9
Compare
gWacey
force-pushed
the
OCT-3012-LED-module-for-kits-with-other-LED-setup
branch
from
7fb59b9 to
1e62820
Compare
|
After documentation is built, you will find the preview for this PR here. |
gWacey
force-pushed
the
OCT-3012-LED-module-for-kits-with-other-LED-setup
branch
from
1e62820 to
a50c58c
Compare
The LED module is currently written in a way that’s highly dependent on all of the LEDs present on the audio DK, which prevents the application from running on the nRF5340 DK. The module must be refactored so that it can still show the state of the application with a different selection of LEDs. Signed-off-by: Graham Wacey <[email protected]>
gWacey
force-pushed
the
OCT-3012-LED-module-for-kits-with-other-LED-setup
branch
from
a50c58c to
238384f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCT-3012
The LED module is currently written in a way that’s highly dependent on all of the LEDs present n the audio DK, which prevents the application from running on the nRF5340 DK. The module must be refactored so that it can still show the state of the application with different selection of LEDs.