Fixes Kconfig options changed in sdk-zephyr #20495

rghaddab · 2025-02-19T13:52:18Z

Fixes Kconfig options changed by this PR: nrfconnect/sdk-zephyr#2525

NordicBuilder · 2025-02-19T13:53:34Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
matter	nrfconnect/sdk-connectedhomeip@`cb40b0d`	nrfconnect/sdk-connectedhomeip#557	nrfconnect/sdk-connectedhomeip#557/files
zephyr	nrfconnect/sdk-zephyr@`16dc0c6`	nrfconnect/sdk-zephyr#2525	nrfconnect/sdk-zephyr#2525/files

⛔ DNM label due to: 2 projects with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

Damian-Nordic · 2025-02-19T13:55:06Z

applications/matter_bridge/boards/nrf54h20dk_nrf54h20_cpuapp.conf

@@ -14,6 +14,7 @@ CONFIG_SSF_PSA_CRYPTO_SERVICE_ENABLED=y
 CONFIG_DCACHE=n

 # Set the ZMS sector count to match the settings partition size that is 32 kB for this application.
+CONFIG_SETTINGS_ZMS_CUSTOM_SECTOR_COUNT=y


It's better to just remove this custom count and use the entire partition.

@Damian-Nordic That's something that I ignore based on each application/sample code.
By default the new backend will use the entire partition.
But I don't know if these applications/sample want to use the entire partition or only the configured number

Each team should verify whether this option is needed for their app/sample or not.
But at least using the CUSTOM_CONFIG that won't change anything in the current configuration

@Damian-Nordic should I removed it for matter sample code ?

Yes, I think for Matter it can be safely removed. For others I'm not sure so you're right it's better to leave this decision to app owners :)

I would say we want to use the full partition. I've changed the sector count, because it turned out that backend implementation does not care about partition size and uses only the size determined by sector count Kconfig. So my solution was sort of workaround. If this is fixed now, I don't think we need custom sector count anymore.

NordicBuilder · 2025-02-19T14:11:46Z

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

NordicBuilder · 2025-02-19T14:18:46Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 14

Inputs:

Sources:

sdk-nrf: PR head: 1cd2d30a8cbee649b0ab83c0ba06de908f78c854
matter: PR head: f0c1631796cc94e95a8bec2e9724d968f6ea5d3a
zephyr: PR head: 1bf0afd13f6c66eec35e9e08bb73e7c61e4bacee

more details

sdk-nrf:

PR head: 1cd2d30a8cbee649b0ab83c0ba06de908f78c854
merge base: ef49118310251ad3b04b8b9e3b5ba0a2693dbaf6
target head (main): ef49118310251ad3b04b8b9e3b5ba0a2693dbaf6
Diff

matter:

PR head: f0c1631796cc94e95a8bec2e9724d968f6ea5d3a
merge base: cb40b0d0dcc8135c7cf9dc78f2b47d89404047ad
target head (master): a85d6b0e6c891119c910a7c81124c6a5ab2b863a
Diff

zephyr:

PR head: 1bf0afd13f6c66eec35e9e08bb73e7c61e4bacee
merge base: 107f9f0cf5369c707282724f7484d708a99ed274
target head (main): b91aa4fec5484f6cd076c9333bb474a7f5c002c1
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (71)

applications
│  ├── matter_bridge
│  │  ├── boards
│  │  │  │ nrf54h20dk_nrf54h20_cpuapp.conf
doc
│  ├── nrf
│  │  ├── app_dev
│  │  │  ├── device_guides
│  │  │  │  ├── nrf54l
│  │  │  │  │  │ zms.rst
modules
│  ├── lib
│  │  ├── matter
│  │  │  ├── .github
│  │  │  │  ├── workflows
│  │  │  │  │  │ examples-nrfconnect.yaml
│  │  │  ├── config
│  │  │  │  ├── nrfconnect
│  │  │  │  │  ├── chip-module
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  │ Kconfig
│  │  │  │  ├── nxp
│  │  │  │  │  ├── chip-module
│  │  │  │  │  │  │ CMakeLists.txt
│  │  │  │  ├── zephyr
│  │  │  │  │  ├── chip-module
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  │ Kconfig.defaults
│  │  │  ├── scripts
│  │  │  │  ├── build
│  │  │  │  │  ├── build
│  │  │  │  │  │  │ targets.py
│  │  │  │  │  ├── builders
│  │  │  │  │  │  │ nrf.py
│  │  │  │  │  ├── testdata
│  │  │  │  │  │  │ all_targets_linux_x64.txt
│  │  │  ├── src
│  │  │  │  ├── app
│  │  │  │  │  ├── tests
│  │  │  │  │  │  │ AppTestContext.cpp
│  │  │  │  ├── platform
│  │  │  │  │  ├── Zephyr
│  │  │  │  │  │  │ PlatformManagerImpl.cpp
│  │  │  │  ├── test_driver
│  │  │  │  │  ├── nrfconnect
│  │  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  │  ├── main
│  │  │  │  │  │  │  ├── include
│  │  │  │  │  │  │  │  │ CHIPProjectConfig.h
│  │  │  │  │  │  │ prj.conf
samples
│  ├── bluetooth
│  │  ├── mesh
│  │  │  ├── ble_peripheral_lbs_coex
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── chat
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── dfu
│  │  │  │  ├── distributor
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  ├── target
│  │  │  │  │  ├── boards
│  │  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── light
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── light_ctrl
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── light_dimmer
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── light_switch
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── sensor_client
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── sensor_server
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  ├── silvair_enocean
│  │  │  │  ├── boards
│  │  │  │  │  ├── nrf54l15dk_nrf54l05_cpuapp.conf
│  │  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  ├── matter
│  │  ├── light_bulb
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── light_switch
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── lock
│  │  │  ├── boards
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── smoke_co_alarm
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp.conf
│  │  ├── template
│  │  │  ├── boards
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l10_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp_internal.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── thermostat
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
│  │  ├── window_covering
│  │  │  ├── boards
│  │  │  │  ├── nrf54l15dk_nrf54l15_cpuapp.conf
│  │  │  │  │ nrf54l15dk_nrf54l15_cpuapp_ns.conf
west.yml
zephyr
│  ├── subsys
│  │  ├── fs
│  │  │  ├── zms
│  │  │  │  ├── Kconfig
│  │  │  │  │ zms.c
│  │  ├── settings
│  │  │  ├── Kconfig
│  │  │  ├── include
│  │  │  │  ├── settings
│  │  │  │  │  │ settings_zms.h
│  │  │  ├── src
│  │  │  │  │ settings_zms.c

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

🟠 Toolchain
🟠 Build twister
🟠 Integration tests
- 🟠 test-sdk-audio
- 🟠 test-fw-nrfconnect-ble_mesh
- 🟠 test-fw-nrfconnect-chip
- 🟠 test-fw-nrfconnect-nfc
- 🟠 test-fw-nrfconnect-nrf-iot_cloud
- 🟠 test-fw-nrfconnect-nrf-iot_thingy91
- 🟠 test-fw-nrfconnect-rs
- 🟠 test-fw-nrfconnect-fem
- 🟠 test-fw-nrfconnect-thread
- 🟠 test-sdk-find-my
- 🟠 test-fw-nrfconnect-nrf-iot_mosh
- 🟠 test-fw-nrfconnect-nrf-iot_positioning
- 🟠 test-sdk-sidewalk
- 🟠 test-low-level

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-zigbee
- test-sdk-dfu
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

github-actions · 2025-02-20T09:01:55Z

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20495/nrf/app_dev/device_guides/nrf54l/zms.html

omkar3141

Since name cache is now replaced by hashing mechanism for ZMS settings backend, the corresponding Kconfig settings are invalid and removed from samples. Looks fine to me.

shanthanordic

agreed for scope

Automatically created by Github Action Signed-off-by: Nordic Builder <[email protected]>

with the new ZMS backend for settings some Kconfig options are not needed and others must be enabled. Signed-off-by: Riadh Ghaddab <[email protected]>

rghaddab requested review from a team and annwoj as code owners February 19, 2025 13:52

github-actions bot added doc-required PR must not be merged without tech writer approval. manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 19, 2025

NordicBuilder added manifest-zephyr DNM labels Feb 19, 2025

rghaddab mentioned this pull request Feb 19, 2025

manifest: sdk-zephyr: New Settings backend for ZMS #20487

Closed

Damian-Nordic approved these changes Feb 19, 2025

View reviewed changes

nordicjm approved these changes Feb 19, 2025

View reviewed changes

rghaddab requested a review from omkar3141 February 19, 2025 14:13

rghaddab force-pushed the rghaddab/pr-20487 branch 2 times, most recently from c429be1 to 9f25d22 Compare February 19, 2025 15:04

NordicBuilder added the manifest-matter label Feb 19, 2025

adigie mentioned this pull request Feb 19, 2025

[nrf toup] [nrfconnect] remove ZMS_LOOKUP_CACHE_FOR_SETTINGS nrfconnect/sdk-connectedhomeip#557

Open

adigie force-pushed the rghaddab/pr-20487 branch from 9f25d22 to 140d3da Compare February 20, 2025 09:01

omkar3141 approved these changes Feb 20, 2025

View reviewed changes

rghaddab force-pushed the rghaddab/pr-20487 branch from 140d3da to d5becbc Compare February 20, 2025 10:08

adigie force-pushed the rghaddab/pr-20487 branch from d5becbc to 646ec80 Compare February 20, 2025 12:14

carlescufi added the backport v2.9-nRF54H20-branch label Feb 20, 2025

adigie force-pushed the rghaddab/pr-20487 branch from 646ec80 to e8f2049 Compare February 20, 2025 15:37

rghaddab force-pushed the rghaddab/pr-20487 branch from e8f2049 to 4774cd9 Compare February 20, 2025 22:47

shanthanordic approved these changes Feb 21, 2025

View reviewed changes

annwoj approved these changes Feb 21, 2025

View reviewed changes

adigie force-pushed the rghaddab/pr-20487 branch from 4774cd9 to 11c4361 Compare February 21, 2025 10:21

NordicBuilder and others added 2 commits February 21, 2025 15:38

manifest: Update sdk-zephyr revision (auto-manifest PR)

bdbf9ba

Automatically created by Github Action Signed-off-by: Nordic Builder <[email protected]>

storage: zms: remove unneeded KCONFIG options

1cd2d30

with the new ZMS backend for settings some Kconfig options are not needed and others must be enabled. Signed-off-by: Riadh Ghaddab <[email protected]>

adigie force-pushed the rghaddab/pr-20487 branch from 11c4361 to 1cd2d30 Compare February 21, 2025 14:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes Kconfig options changed in sdk-zephyr #20495

Fixes Kconfig options changed in sdk-zephyr #20495

rghaddab commented Feb 19, 2025

NordicBuilder commented Feb 19, 2025 •

edited

Loading

Damian-Nordic Feb 19, 2025

rghaddab Feb 19, 2025 •

edited

Loading

rghaddab Feb 19, 2025

rghaddab Feb 19, 2025

Damian-Nordic Feb 19, 2025

kkasperczyk-no Feb 19, 2025

NordicBuilder commented Feb 19, 2025

NordicBuilder commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 20, 2025 •

edited

Loading

omkar3141 left a comment

shanthanordic left a comment

Fixes Kconfig options changed in sdk-zephyr #20495

Are you sure you want to change the base?

Fixes Kconfig options changed in sdk-zephyr #20495

Conversation

rghaddab commented Feb 19, 2025

NordicBuilder commented Feb 19, 2025 • edited Loading

Damian-Nordic Feb 19, 2025

Choose a reason for hiding this comment

rghaddab Feb 19, 2025 • edited Loading

Choose a reason for hiding this comment

rghaddab Feb 19, 2025

Choose a reason for hiding this comment

rghaddab Feb 19, 2025

Choose a reason for hiding this comment

Damian-Nordic Feb 19, 2025

Choose a reason for hiding this comment

kkasperczyk-no Feb 19, 2025

Choose a reason for hiding this comment

NordicBuilder commented Feb 19, 2025

NordicBuilder commented Feb 19, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

github-actions bot commented Feb 20, 2025 • edited Loading

omkar3141 left a comment

Choose a reason for hiding this comment

shanthanordic left a comment

Choose a reason for hiding this comment

NordicBuilder commented Feb 19, 2025 •

edited

Loading

rghaddab Feb 19, 2025 •

edited

Loading

NordicBuilder commented Feb 19, 2025 •

edited

Loading

github-actions bot commented Feb 20, 2025 •

edited

Loading