nrf_modem: update build system files #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlubos
approved these changes
Oct 11, 2023
nrf_modem/Kconfig
Outdated
| This increases the final size of the application. | ||
| Link with the default binary. | ||
|
|
||
| config NRF_MODEM_BINARY_LOG |
There was a problem hiding this comment.
I'm wondering whether we should keep NRF_MODEM_LOG to enable modem library logs(?). This changes the Kconfig option to enable library logs and requires an update to the documentation.
There was a problem hiding this comment.
Would it makes sense to keep NRF_MODEM_LOG and have that select the binary version?
There was a problem hiding this comment.
Yes, it would. That's a good point, I will change that.
lemrey
force-pushed
the
nrf-modem-choice
branch
from
d498340 to
e54a0b1
Compare
Add license to KConfig file. Signed-off-by: Emanuele Di Santo <[email protected]>
This doesn't really belong here. It should rather be turned on by the application, if needed. Signed-off-by: Emanuele Di Santo <[email protected]>
The library depends on a full libc implementation with variadic printf and scanf. It also needs the IPC driver. Signed-off-by: Emanuele Di Santo <[email protected]>
Reword prompt. Signed-off-by: Emanuele Di Santo <[email protected]>
lemrey
force-pushed
the
nrf-modem-choice
branch
from
e54a0b1 to
fa9c3ab
Compare
|
Have changed the commits, please revist. |
eivindj-nordic
approved these changes
Nov 14, 2023
| @@ -1,10 +1,15 @@ | |||
| # | |||
| # Copyright (c) 2023 Nordic Semiconductor | |||
There was a problem hiding this comment.
nit: This file is older than this
rlubos
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a Kconfig choice for the binary version.