Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Don't run sdk-sidewalk tests on SDC updates #1105

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

rugeGerritsen
Copy link
Contributor

We have sufficient coverage by building and running other tests.

We have sufficient coverage by building and running other tests.

Signed-off-by: Rubin Gerritsen <[email protected]>
@rugeGerritsen rugeGerritsen requested a review from a team as a code owner October 31, 2023 13:49
@totyz totyz self-requested a review October 31, 2023 14:52
Copy link
Contributor

@totyz totyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK for me.
Upstream plan is built Sidewalk samples, so any problem with building will be found there.

@thst-nordic
Copy link
Contributor

Test-spec changes don't strictly require their own PR.
Free to add as a commit to nrfconnect/sdk-nrf#12833 next time.

@rugeGerritsen rugeGerritsen merged commit e178ddc into nrfconnect:main Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants