Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf_wifi: Support for CSP package in Host driver #1199

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

imapa
Copy link
Contributor

@imapa imapa commented Feb 6, 2024

SHEL-2310: Modify host driver to read package type from OTP. Use this package type information to pick RF parameters.

@@ -1807,6 +1807,33 @@ enum nrf_wifi_status nrf_wifi_hal_otp_ft_prog_ver_get(struct nrf_wifi_hal_dev_ct
return status;
}

enum nrf_wifi_status nrf_wifi_hal_otp_pack_info_get(struct nrf_wifi_hal_dev_ctx *hal_dev_ctx,
unsigned int *package_info)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent needs to be fixed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -849,7 +858,7 @@ enum nrf_wifi_status nrf_wifi_fmac_get_reg(struct nrf_wifi_fmac_dev_ctx *fmac_de

int nrf_wifi_phy_rf_params_init(struct nrf_wifi_osal_priv *opriv,
struct nrf_wifi_phy_rf_params *prf,
unsigned char package_info,
unsigned int package_info,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to make this change in a separate commit explaining the why

@@ -661,6 +661,15 @@ enum nrf_wifi_status nrf_wifi_fmac_rf_params_get(
goto out;
}

status = nrf_wifi_hal_otp_pack_info_get(fmac_dev_ctx->hal_dev_ctx,
&package_info);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -199,3 +199,6 @@ enum nrf_wifi_status nrf_wifi_hal_otp_info_get(struct nrf_wifi_hal_dev_ctx *hal_

enum nrf_wifi_status nrf_wifi_hal_otp_ft_prog_ver_get(struct nrf_wifi_hal_dev_ctx *hal_dev_ctx,
unsigned int *ft_prog_ver);

enum nrf_wifi_status nrf_wifi_hal_otp_pack_info_get(struct nrf_wifi_hal_dev_ctx *hal_dev_ctx,
unsigned int *package_info);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sachinthegreen sachinthegreen added this to the 2.6.0 milestone Feb 6, 2024
Copy link
Contributor

@sachinthegreen sachinthegreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manifest PR in NordicPlayground ?

[SHEL-2310]: Modify host driver to read package type from OTP.
Use this package type information to pick RF parameters.

Signed-off-by: Mahammadyunus Patil <[email protected]>
@imapa
Copy link
Contributor Author

imapa commented Feb 7, 2024

manifest PR in NordicPlayground ?

NordicPlayground/nrf70-linux-driver#57

@rlubos rlubos merged commit 622afe1 into nrfconnect:main Feb 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants