Skip to content

Commit

Permalink
build: remove experimental warning for thingy53
Browse files Browse the repository at this point in the history
KRKNWK-18382

Signed-off-by: Robert Gałat <[email protected]>
  • Loading branch information
RobertGalatNordic authored and totyz committed Feb 29, 2024
1 parent d6ffdf5 commit dd1ce02
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 11 deletions.
5 changes: 0 additions & 5 deletions Kconfig.dependencies
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ config SIDEWALK_BUILD
help
An internal config to build the NCS Sidewalk Sources.

config SIDEWALK_THINGY53_SUPPORT
bool "Sidewalk support for Thingy:53 [EXPERIMENTAL]"
select EXPERIMENTAL
default BOARD_THINGY53_NRF5340_CPUAPP && SIDEWALK

config SIDEWALK_BLE
bool
default SIDEWALK
Expand Down
2 changes: 2 additions & 0 deletions doc/includes/include_kconfig_common.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
* ``CONFIG_SID_END_DEVICE_CLI`` -- Enables Sidewalk CLI.
To see the list of available commands, flash the sample and type ``sid help``.

* ``CONFIG_SIDEWALK_ON_DEV_CERT`` -- Enables the on-device certification Shell.

* ``CONFIG_SID_END_DEVICE_AUTO_START`` -- Enables an automatic Sidewalk initialization and start.

* ``CONFIG_SID_END_DEVICE_AUTO_CONN_REQ`` -- Enables an automatic connection request before sending a message.
Expand Down
2 changes: 2 additions & 0 deletions doc/ncs_links.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,14 @@
.. _nRF Connect SDK: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/index.html
.. _nrf52840 DK: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/config_and_build/board_support.html#boards-included-in-sdk-zephyr
.. _nrf5340 DK: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/config_and_build/board_support.html#boards-included-in-sdk-zephyr
.. _Thingy53: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/config_and_build/board_support.html#boards-included-in-sdk-zephyr
.. _Getting started with nRF52 Series: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/device_guides/working_with_nrf/nrf52/gs.html
.. _Getting started with nRF53 Series: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/device_guides/nrf53.html
.. _Zephyr toolchain: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/gs_installing.html#install-a-toolchain
.. _nRF Connect SDK Getting started: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/getting_started.html
.. _nRF52840dk_nrf52840: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/zephyr/boards/arm/nrf52840dk_nrf52840/doc/index.html
.. _nrf5340dk_nrf5340: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/zephyr/boards/arm/nrf5340dk_nrf5340/doc/index.html#nrf5340dk-nrf5340
.. _thingy53_nrf5340: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/zephyr/boards/arm/thingy53_nrf5340/doc/index.html#thingy53-nrf5340
.. _Building and programming an application: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/getting_started/programming.html#gs-programming
.. _Testing and debugging an application: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/getting_started/testing.html#gs-testing
.. _Bootloader and DFU solutions for NCS: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/2.5.99-dev1/nrf/app_bootloaders.html
Expand Down
2 changes: 2 additions & 0 deletions doc/ncs_links_update.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,14 @@ cd $current_dir
links=( ".. _nRF Connect SDK: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/index.html"
".. _nrf52840 DK: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/config_and_build/board_support.html#boards-included-in-sdk-zephyr"
".. _nrf5340 DK: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/config_and_build/board_support.html#boards-included-in-sdk-zephyr"
".. _Thingy53: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/config_and_build/board_support.html#boards-included-in-sdk-zephyr"
".. _Getting started with nRF52 Series: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/device_guides/working_with_nrf/nrf52/gs.html"
".. _Getting started with nRF53 Series: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/device_guides/nrf53.html"
".. _Zephyr toolchain: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/gs_installing.html#install-a-toolchain"
".. _nRF Connect SDK Getting started: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/getting_started.html"
".. _nRF52840dk_nrf52840: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/zephyr/boards/arm/nrf52840dk_nrf52840/doc/index.html"
".. _nrf5340dk_nrf5340: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/zephyr/boards/arm/nrf5340dk_nrf5340/doc/index.html#nrf5340dk-nrf5340"
".. _thingy53_nrf5340: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/zephyr/boards/arm/thingy53_nrf5340/doc/index.html#thingy53-nrf5340"
".. _Building and programming an application: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/getting_started/programming.html#gs-programming"
".. _Testing and debugging an application: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/getting_started/testing.html#gs-testing"
".. _Bootloader and DFU solutions for NCS: https://developer.nordicsemi.com/nRF_Connect_SDK/doc/<NCS_TAG>/nrf/app_bootloaders.html"
Expand Down
1 change: 1 addition & 0 deletions doc/samples/samples_list.rst
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ The following table demonstrates the variants' configuration for the supported d
+-----------------------------------+------------------------------------------+-----------------------------+--------------------------------------------------------------------------+-----------------------------------------------+-------------------------------+
| :ref:`variant_sensor_monitoring` | Demo application of Sidewalk protocol | * `nRF52840 DK`_ | * External flash (included in the DK) | * MCUboot - DFU partition in external flash | * ``overlay-demo.conf`` |
| | with temperature sensor monitoring. | * `nRF5340 DK`_ | * `Semtech SX1262MB2CAS`_ (only for the configurations with LoRa or FSK) | * Application partition size = 956 kB | |
| | | * `Thingy53`_ | | | |
+-----------------------------------+------------------------------------------+-----------------------------+--------------------------------------------------------------------------+-----------------------------------------------+-------------------------------+
| :ref:`variant_sidewalk_dut` | Device under test generic application | * `nRF52840 DK`_ | * External flash (included in the DK) | * MCUboot - DFU partition in external flash | * ``overlay-dut.conf`` |
| | having activated CLI. | * `nRF5340 DK`_ | * `Semtech SX1262MB2CAS`_ (only for the configurations with LoRa or FSK) | * Application partition size = 956 kB | |
Expand Down
10 changes: 7 additions & 3 deletions doc/samples/sid_end_device.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ This sample supports the following development kits:
+--------------------+----------+------------------------+------------------------------+
| nRF5340 DK | PCA10095 | `nrf5340dk_nrf5340`_ | ``nrf5340dk_nrf5340_cpuapp`` |
+--------------------+----------+------------------------+------------------------------+
| Thingy53 | PCA20053 | `thingy53_nrf5340`_ | ``thingy53_nrf5340_cpuapp`` |
+--------------------+----------+------------------------+------------------------------+

To run the sample in the Bluetooth LE link mode, you only need the development kit.
However, if you want to run the sample with LoRa or FSK configuration, you also need the LoRa radio module.
Expand Down Expand Up @@ -53,9 +55,6 @@ Source file setup
The application consists of two source files:

* :file:`main.c` -- The main source file. Starts Sidewalk application.
* :file:`app.c` (:file:`app.h`) -- Variant-specific file.
It communicates to the Sidewalk thread using events defined in the :file:`sidewalk.h` file, and receives Sidewalk callbacks defined in the :file:`sid_api.h` file.
An application may consist of multiple ``app_*`` files that are used to define user interface and realize application logic.
* :file:`sidewalk.c` (:file:`sidewalk.h`) -- Sidewalk thread file.
It is a common source file for all sample configurations.
It implements a separate thread that calls the Sidewalk API.
Expand All @@ -67,6 +66,11 @@ The application consists of two source files:

Sidewalk thread state machine.

Additionally, it has a variant-specific file:

* :file:`app.c` (:file:`app.h`) -- Implements application logic.
It communicates to the Sidewalk thread using events defined in the :file:`sidewalk.h` file, and receives Sidewalk callbacks defined in the :file:`sid_api.h` file.
An application may consist of multiple ``app_*`` files that are used to define user interface and realize application logic.

.. _sidewalk_end_device_configuration:

Expand Down
2 changes: 1 addition & 1 deletion doc/samples/variants/sensor_monitoring.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ You can find an application server (cloud backend with web UI) compatible with t
Source file setup
*****************

The application consists of two source files:
The application consists of the following source files:

* :file:`app.c` (:file:`app.h`) -- The main application file starts the TX and RX thread, assigns button actions to the buttons on the board, and adds received messages to the received message queue.
* :file:`app_sensor.c`, :file:`app_button.c`, :file:`app_led.c` -- The files implement interface between the hardware and sample application.
Expand Down
2 changes: 2 additions & 0 deletions samples/sid_end_device/boards/thingy53_nrf5340_cpuapp.conf
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,5 @@ CONFIG_NRF53_ENFORCE_IMAGE_VERSION_EQUALITY=y
CONFIG_I2C=y
CONFIG_SENSOR=y
CONFIG_BME680=y

CONFIG_SIDEWALK_SUBGHZ_SUPPORT=n
3 changes: 1 addition & 2 deletions utils/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,5 @@ endif # SIDEWALK_DFU_SERVICE_BLE


config SIDEWALK_ON_DEV_CERT
bool "Enable on device certification [EXPERIMENTAL]"
bool "Enable on device certification"
depends on SHELL
select EXPERIMENTAL

0 comments on commit dd1ce02

Please sign in to comment.