Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add nrf54 to sidewalk tests #521

Merged

Conversation

RobertGalatNordic
Copy link
Collaborator

KRKNWK-18680
Allow building tests for nrf54l15

@RobertGalatNordic RobertGalatNordic requested a review from totyz March 20, 2024 09:07
@github-actions github-actions bot added source PR changing src files tests labels Mar 20, 2024
Copy link

github-actions bot commented Mar 20, 2024

Sample diff used total
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.demo RAM 97.5 KB 97.5 KB 256 KB
ROM 354.01 KB 354.01 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.demo.ble_only RAM 97.5 KB 97.5 KB 256 KB
ROM 353.75 KB 353.75 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.dut RAM 121.15 KB 121.15 KB 256 KB
ROM 417.42 KB 417.42 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello RAM 87.55 KB 87.55 KB 256 KB
ROM 353.51 KB 353.51 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello.ble_only RAM 87.55 KB 87.55 KB 256 KB
ROM 353.26 KB 353.26 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello.ble_only.release RAM 82.71 KB 82.71 KB 256 KB
ROM 289.07 KB 289.07 KB 730 KB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello.no_dfu RAM 74.27 KB 74.27 KB 256 KB
ROM 334.67 KB 334.67 KB 1.48 MB
nrf54l15pdk_nrf54l15_cpuapp:sample.sidewalk.hello.release RAM 82.71 KB 82.71 KB 256 KB
ROM 289.2 KB 289.2 KB 730 KB

@RobertGalatNordic RobertGalatNordic force-pushed the KRKNWK-18680_enable_nrf54l15 branch 5 times, most recently from 0a36197 to 3d4cb15 Compare March 22, 2024 15:16
@RobertGalatNordic RobertGalatNordic force-pushed the KRKNWK-18680_enable_nrf54l15 branch 2 times, most recently from 3721b9b to c80c601 Compare March 27, 2024 10:57
@github-actions github-actions bot added the sid-lib PR changing Sidewalk libraries label Mar 27, 2024
@ktaborowski ktaborowski force-pushed the KRKNWK-18680_enable_nrf54l15 branch from 87c0db3 to a9101c3 Compare March 27, 2024 15:44
@RobertGalatNordic RobertGalatNordic force-pushed the KRKNWK-18680_enable_nrf54l15 branch from a9101c3 to ac4b404 Compare March 28, 2024 08:34
@ktaborowski ktaborowski force-pushed the KRKNWK-18680_enable_nrf54l15 branch 5 times, most recently from ea01047 to c954aca Compare March 28, 2024 12:30
@RobertGalatNordic RobertGalatNordic marked this pull request as ready for review March 29, 2024 08:12
RobertGalatNordic and others added 5 commits April 2, 2024 15:11
KRKNWK-18680
Allow building tests for nrf54l15
Fix configuration of crypto test
Crypto clean up test config

Signed-off-by: Robert Gałat <[email protected]>
KRKNWK-18680
add nrf54 to automated test detection for twister

Signed-off-by: Robert Gałat <[email protected]>
KRKNWK-18680
disable temperature test, as it will fail for nrf54

Signed-off-by: Robert Gałat <[email protected]>
[KRKNWK-18680]
Disable isr for buttons (experimental)
led 3 and 5 on port2 does not support it.
Disable sub-GHz configuration
start with ble only with default dts.

Signed-off-by: Krzysztof Taborowski <[email protected]>
[KRKNWK-18680]
Configuration tested on PCA10156 v0.2.1 (ES-5)

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski force-pushed the KRKNWK-18680_enable_nrf54l15 branch 2 times, most recently from 9da0df6 to 50a382e Compare April 3, 2024 08:03
[KRKNWK-18680]
No dfu configuration may has different address
on different platforms e.g. when flash is larger.

Minor improvements:
Remove duplicated configuration.
Make code comment more precise.

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski force-pushed the KRKNWK-18680_enable_nrf54l15 branch from 50a382e to 1c19649 Compare April 4, 2024 07:35
Copy link
Contributor

@totyz totyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests PASSED, nrf54 works, no regression found so far

@ktaborowski ktaborowski merged commit 68c3a8c into nrfconnect:main Apr 5, 2024
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scripts sid-lib PR changing Sidewalk libraries source PR changing src files tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants