Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: doc adjustments after zoomin migration #564

Merged
merged 1 commit into from
May 23, 2024
Merged

doc: doc adjustments after zoomin migration #564

merged 1 commit into from
May 23, 2024

Conversation

annwoj
Copy link
Contributor

@annwoj annwoj commented May 22, 2024 •
edited
Loading

moved all links to one file - they are now included automatically in all articles through conf.py
aligned doc adjustments to zoomin packages (removed obsolete known issues)
included some other small changes

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

@annwoj annwoj added the doc-required PR must not be merged without tech writer approval. label May 22, 2024
@github-actions github-actions bot added the source PR changing src files label May 22, 2024
@annwoj annwoj force-pushed the zoomin-adjustments branch from a4c9e70 to a2d3605 Compare May 22, 2024 11:36
@annwoj annwoj marked this pull request as ready for review May 22, 2024 11:37
@annwoj annwoj force-pushed the zoomin-adjustments branch from a2d3605 to a19daf2 Compare May 22, 2024 11:40
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Sample diff used total
[email protected]/nrf54l15/cpuapp:sample.sidewalk.dut RAM 112.58 KB 136.38 KB 256 KB
ROM 468.31 KB 494.1 KB 730 KB
[email protected]/nrf54l15/cpuapp:sample.sidewalk.hello RAM 78.89 KB 102.69 KB 256 KB
ROM 405.41 KB 431.2 KB 730 KB
[email protected]/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 58.71 KB 82.5 KB 256 KB
ROM 259.4 KB 285.19 KB 730 KB
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 91.77 KB 109.77 KB 256 KB
ROM 469.71 KB 495.81 KB 983.5 KB
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM -86.89 KB 18 KB 256 KB
ROM -404.22 KB 26.1 KB 28 KB
[email protected]/nrf54l15/cpuapp:sample.sidewalk.demo RAM -89.72 KB 23.8 KB 256 KB
ROM -406.4 KB 25.79 KB 48 KB

@annwoj
doc: doc adjustments after zoomin migration
39b68bf 
moved all links to one file
they are now included automatically in all articles through conf.py
aligned doc adjustments to zoomin packages
included some other small changes

Signed-off-by: Anna Wojdylo <[email protected]>
@annwoj annwoj force-pushed the zoomin-adjustments branch from a19daf2 to 39b68bf Compare May 22, 2024 11:58
ktaborowski
ktaborowski approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@ktaborowski ktaborowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@annwoj annwoj merged commit 8e35be5 into nrfconnect:main May 23, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktaborowski ktaborowski ktaborowski approved these changes

@RobertGalatNordic RobertGalatNordic Awaiting requested review from RobertGalatNordic

@totyz totyz Awaiting requested review from totyz

@wojciechpluszynski wojciechpluszynski Awaiting requested review from wojciechpluszynski

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. source PR changing src files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@annwoj @ktaborowski