Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pal: new provisioing module #591

Merged
merged 10 commits into from
Sep 9, 2024
Merged

pal: new provisioing module #591

merged 10 commits into from
Sep 9, 2024

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Aug 2, 2024 •
edited
Loading

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: main

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket: KRKNWK-18440

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added source PR changing src files tests labels Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024 •
edited
Loading

Sample diff used total
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.dut RAM 4.02 KB 139.27 KB 0 B
ROM 11.73 KB 495.55 KB 0 B
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 4.01 KB 116.75 KB 0 B
ROM 11.62 KB 441.23 KB 0 B
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 4.01 KB 90.03 KB 0 B
ROM 11.59 KB 345.54 KB 0 B
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 4.01 KB 85.26 KB 0 B
ROM 9.67 KB 277.84 KB 0 B
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 4.01 KB 100.64 KB 0 B
ROM 9.71 KB 354.1 KB 0 B
thingy53/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 5.02 KB 105.36 KB 0 B
ROM 8.04 KB 336.17 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo RAM 4.02 KB 118.82 KB 0 B
ROM 9.2 KB 435.83 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM 4.02 KB 103.33 KB 0 B
ROM 9.18 KB 353.55 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM 4.03 KB 142.4 KB 0 B
ROM 9.37 KB 500.98 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 4.02 KB 119.98 KB 0 B
ROM 9.22 KB 450.52 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM 4.02 KB 93.16 KB 0 B
ROM 9.16 KB 351.8 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM 4.02 KB 88.33 KB 0 B
ROM 6.96 KB 289.14 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM 4.02 KB 103.83 KB 0 B
ROM 7 KB 367.56 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo RAM 5.02 KB 110.84 KB 0 B
ROM 8.09 KB 376.02 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.demo.ble_only RAM 5.02 KB 95.65 KB 0 B
ROM 8.04 KB 297.38 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut RAM 5.02 KB 134.55 KB 0 B
ROM 8.27 KB 441.24 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello RAM 5.02 KB 112.27 KB 0 B
ROM 8.08 KB 390.96 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only RAM 5.02 KB 85.74 KB 0 B
ROM 8.04 KB 295.87 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.ble_only.release RAM 5.02 KB 81.08 KB 0 B
ROM 5.95 KB 230.71 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.hello.release RAM 5.02 KB 96.27 KB 0 B
ROM 6 KB 306.22 KB 0 B
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.demo RAM 4.01 KB 115.36 KB 0 B
ROM 11.62 KB 426.57 KB 0 B
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 4.01 KB 99.99 KB 0 B
ROM 11.58 KB 347.3 KB 0 B
nrf54l15pdk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM 139.26 KB 139.26 KB 0 B
ROM 484.69 KB 484.69 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM 142.38 KB 142.38 KB 0 B
ROM 492.47 KB 492.47 KB 0 B
nrf5340dk/nrf5340/cpuapp:sample.sidewalk.dut.no_secure RAM 134.53 KB 134.53 KB 0 B
ROM 433.83 KB 433.83 KB 0 B

@ktaborowski ktaborowski force-pushed the new_mfg_pal branch 3 times, most recently from fd3a4f3 to 6a8a9ba Compare August 5, 2024 15:13
@ktaborowski ktaborowski marked this pull request as ready for review August 6, 2024 06:44
@ktaborowski ktaborowski force-pushed the new_mfg_pal branch 3 times, most recently from bc852e8 to 1dd133b Compare August 8, 2024 07:55
@totyz totyz self-requested a review August 19, 2024 08:52
@RobertGalatNordic RobertGalatNordic force-pushed the new_mfg_pal branch 7 times, most recently from 009b009 to cb2f961 Compare August 23, 2024 11:43
@RobertGalatNordic
Copy link
Collaborator

RobertGalatNordic commented Aug 27, 2024 •
edited
Loading

https://jenkins-ncs.nordicsemi.no/job/KRKNG/job/Sidewalk/job/test-sdk-sidewalk/job/mfg-tlv-as-default/33/

@RobertGalatNordic RobertGalatNordic force-pushed the new_mfg_pal branch 6 times, most recently from bb33df5 to cc44850 Compare August 28, 2024 10:55
@RobertGalatNordic
Copy link
Collaborator

CONFIG_SIDEWALK_CRYPTO_PSA_KEY_STORAGE=y
CONFIG_SIDEWALK_CRYPTO_LOG_LEVEL_DBG=y
CONFIG_SIDEWALK_MFG_STORAGE_V2=y

@totyz
Copy link
Contributor

totyz commented Sep 4, 2024

Please add new sample to sample.yaml:

  sample.sidewalk.dut.no_secure:
    extra_args:
      OVERLAY_CONFIG="overlay-dut.conf"
    extra_configs:
      - ...
    tags: Sidewalk cli no_secure

@RobertGalatNordic RobertGalatNordic force-pushed the new_mfg_pal branch 3 times, most recently from 448186a to 7650eea Compare September 4, 2024 10:30
@ktaborowski
tests: add zephyr kconfigs
1bbcc23 
Add zephyr kconfigs in test projects

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
pal: on dev cert support secure keys
2aed5b4 
[KRKNWK-19108]

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski ktaborowski force-pushed the new_mfg_pal branch 2 times, most recently from e772e20 to b1ce543 Compare September 4, 2024 13:57
@ktaborowski @RobertGalatNordic
pal: new mfg data processing flow
ca09f3e 
[KRKNWK-18440]

Signed-off-by: Krzysztof Taborowski <[email protected]>
Co-authored-by: Robert Gałat <[email protected]>
Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
pal: fix unilitialized variables
2115882 
for static code analysis

Signed-off-by: Krzysztof Taborowski <[email protected]>
RobertGalatNordic and others added 2 commits September 5, 2024 12:11
@RobertGalatNordic @ktaborowski
mfg: enable mfg_hex v7 by default
75ea36d 
make both parsers avaliable by default

Signed-off-by: Robert Gałat <[email protected]>
@ktaborowski
pal: fix public key generation for secp256r1
90f098d 
The SECPxxx public key contains additional constant byte (prefix)
on the buffer beginning, to backward compatibility this byte is skipped

Signed-off-by: Krzysztof Taborowski <[email protected]>
@RobertGalatNordic
on_dev_cert: fix issue with missing flags in mfg
ab30dbc 
fix the macro to exclude private keys if are stored in psa

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic RobertGalatNordic force-pushed the new_mfg_pal branch 3 times, most recently from b0d93b4 to 282e33f Compare September 5, 2024 14:25
@RobertGalatNordic
tlv: add erase to tlv API
0b30ecf 
flash erase may be impossible to execute on arbitraty
size and address, therefor separate function is provided

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic
crypto: initialize crypto on crypto_keys init
66048e3 
make sure that crypto is initialized before use of crypto_keys

Signed-off-by: Robert Gałat <[email protected]>
@ktaborowski
pal: crypto keys error code when not found
aa23bf6 
fix error when deleting keys
when they were never added

Signed-off-by: Krzysztof Taborowski <[email protected]>
totyz
totyz approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@totyz totyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests PASSED

@ktaborowski ktaborowski merged commit 7238295 into nrfconnect:main Sep 9, 2024
56 of 57 checks passed
@ktaborowski ktaborowski deleted the new_mfg_pal branch September 13, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarGasiorek MarGasiorek MarGasiorek left review comments

@totyz totyz totyz approved these changes

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

Assignees
No one assigned
Labels
source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ktaborowski @RobertGalatNordic @totyz @MarGasiorek