Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: new mcuboot configuration #652

Merged
merged 2 commits into from
Dec 13, 2024
Merged

samples: new mcuboot configuration #652

merged 2 commits into from
Dec 13, 2024

Conversation

ktaborowski
Copy link
Contributor

@ktaborowski ktaborowski commented Dec 4, 2024 •
edited
Loading

Changes:

CI parameters

Github_actions:
  #(branch, hash, pull/XXX/head)
  NRF_revision: pull/19148/head

  # Do not change after creating PR
  Create_NRF_PR: false
Jenkins:
  test-sdk-sidewalk: master

Description

JIRA ticket:

Self review

  • There is no commented code.
  • There are no TODO/FIXME comments without associated issue ticket.
  • Commits are properly organized.
  • Change has been tested.
  • Tests were updated (if applicable).

@github-actions github-actions bot added the source PR changing src files label Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Sample diff used total
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo.ble_only RAM 0 B 105.82 KB 0 B
ROM 24 B 328.48 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut RAM 0 B 144.62 KB 0 B
ROM 24 B 472.93 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.ble_only RAM 0 B 129.51 KB 0 B
ROM 24 B 394.64 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.no_secure RAM 0 B 144.62 KB 0 B
ROM 24 B 470.23 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello RAM 0 B 122.31 KB 0 B
ROM 24 B 421.53 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only RAM 0 B 95.87 KB 0 B
ROM 24 B 326.78 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only.release RAM 0 B 91.23 KB 0 B
ROM 24 B 256.3 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.release RAM 0 B 106.29 KB 0 B
ROM 24 B 332.17 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM 0 B 121.65 KB 0 B
ROM 24 B 456.25 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 106.6 KB 0 B
ROM 24 B 378.49 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM 0 B 145.4 KB 0 B
ROM 24 B 522.71 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.ble_only RAM 0 B 130.29 KB 0 B
ROM 24 B 444.42 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM 0 B 145.38 KB 0 B
ROM 24 B 515.02 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 0 B 123.09 KB 0 B
ROM 24 B 471.54 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 96.64 KB 0 B
ROM 24 B 376.79 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 0 B 92.01 KB 0 B
ROM 24 B 305.37 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 0 B 107.07 KB 0 B
ROM 24 B 381.24 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo RAM 0 B 123.74 KB 0 B
ROM -16 B 478.81 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM 0 B 108.4 KB 0 B
ROM -16 B 396.32 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM 0 B 147.38 KB 0 B
ROM -16 B 544.78 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.ble_only RAM 0 B 131.98 KB 0 B
ROM -16 B 461.67 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM 0 B 147.36 KB 0 B
ROM -16 B 536.22 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 0 B 124.97 KB 0 B
ROM -16 B 494.11 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM 0 B 98.23 KB 0 B
ROM -16 B 394.66 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM 0 B 93.42 KB 0 B
ROM -16 B 325.29 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM 0 B 108.77 KB 0 B
ROM -16 B 404.26 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo RAM 0 B 121.65 KB 0 B
ROM 24 B 456.22 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 106.6 KB 0 B
ROM 24 B 378.46 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut RAM 0 B 145.4 KB 0 B
ROM 24 B 522.68 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.ble_only RAM 0 B 130.29 KB 0 B
ROM 24 B 444.39 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.no_secure RAM 0 B 145.38 KB 0 B
ROM 24 B 514.99 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello RAM 0 B 123.09 KB 0 B
ROM 24 B 471.5 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 96.64 KB 0 B
ROM 24 B 376.76 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only.release RAM 0 B 92.01 KB 0 B
ROM 24 B 305.34 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.release RAM 0 B 107.07 KB 0 B
ROM 24 B 381.21 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo RAM 0 B 120.87 KB 0 B
ROM 24 B 406.22 KB 0 B

@ktaborowski ktaborowski mentioned this pull request Dec 4, 2024
Open
@ktaborowski ktaborowski force-pushed the mcuboot_ed25519 branch 3 times, most recently from a8aea8a to 09a849f Compare December 4, 2024 14:06
@ktaborowski
samples: new mcuboot configuration
df0a2ce 
* all platforms: size optimization in mcuboot
* nrf54L: ed25519 signature as default (from nrf)
nrfconnect/sdk-nrf#19148
* nrf54L10: link time optimization in mcuboot
* nrf54L10: mcuboot partition size set to 52 KB

Signed-off-by: Krzysztof Taborowski <[email protected]>
@ktaborowski
tests: align mcuboot configuration in test app
2625c7d 
[KRKNWK-19763]

Signed-off-by: Krzysztof Taborowski <[email protected]>
@github-actions github-actions bot added the tests label Dec 9, 2024
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Dec 9, 2024
nordicjm
nordicjm reviewed Dec 10, 2024
View reviewed changes
tests/manual/simple_bootloader/Kconfig.sysbuild
endif # (BOARD_NRF5340DK_NRF5340_CPUAPP || BOARD_THINGY53_NRF5340_CPUAPP)

config PM_EXTERNAL_FLASH_MCUBOOT_SECONDARY
default y if BOARD_NRF52840DK_NRF52840 || BOARD_NRF5340DK_NRF5340_CPUAPP || BOARD_THINGY53_NRF5340_CPUAPP
if (BOARD_NRF54L15DK_NRF54L15_CPUAPP || BOARD_NRF54L15DK_NRF54L15_CPUAPP_NS || BOARD_NRF54L15DK_NRF54L10_CPUAPP)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use SOC series Kconfig instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in next pr: #659
should be quick to merge, then I rebase this one

@ktaborowski ktaborowski merged commit 83f8c85 into nrfconnect:main Dec 13, 2024
113 checks passed
@ktaborowski ktaborowski mentioned this pull request Dec 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nordicjm nordicjm nordicjm left review comments

@RobertGalatNordic RobertGalatNordic RobertGalatNordic approved these changes

@totyz totyz Awaiting requested review from totyz

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. source PR changing src files tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ktaborowski @nordicjm @RobertGalatNordic